Skip to content

[ScrollArea] Add data-orientation to Scrollbar #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2021
Merged

[ScrollArea] Add data-orientation to Scrollbar #720

merged 1 commit into from
Jun 17, 2021

Conversation

benoitgrelard
Copy link
Contributor

Fix #719

andy-hook
andy-hook approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@andy-hook andy-hook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. It might be worth us adding an example of using multiple bars when we update the docs.

@benoitgrelard benoitgrelard merged commit 3e3bda1 into main Jun 17, 2021
@benoitgrelard benoitgrelard deleted the 719-scrollarea-add-orientation-attr branch June 17, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-hook andy-hook andy-hook approved these changes

@jjenzz jjenzz Awaiting requested review from jjenzz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ScrollArea] Scrollbar part doesn't have data-orientation attribute for styling convenience
2 participants
@benoitgrelard @andy-hook