[Slider] Fix sticky value with keyboard #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -117,7 +117,7 @@ const Slider = React.forwardRef((props, forwardedRef) => { | |||
| const nextValues = getNextSortedValues(prevValues, nextValue, atIndex); | |||
| if (hasMinStepsBetweenValues(nextValues, minStepsBetweenThumbs * step)) { | |||
| valueIndexToChangeRef.current = nextValues.indexOf(nextValue); | |||
| return nextValues[atIndex] !== prevValues[atIndex] ? nextValues : prevValues; | |||
| return String(nextValues) === String(prevValues) ? prevValues : nextValues; | |||
There was a problem hiding this comment.
I understand the change, but I can't wrap my head around why the previous way would create the keyboard bug yet this wouldn't. 🤔
There was a problem hiding this comment.
For anyone else following along, without this change we ended up with something like this:
- arrow press, values [15,16,20] (atIndex = 0, valueIndexToChange = 0)
- arrow press, values [16,16,20] (atIndex = 0, valueIndexToChange = 0)
- arrow press, values [16,17,20] (atIndex = 0, valueIndexToChange = 1)
That last array would then check nextValues[0] !== prevValues[0] (16 !== 16) which would be equal and return the prevValues.
I could have changed this to return nextValues[valueIndexToChangeRef.current] !== prevValues[valueIndexToChangeRef.current] ? nextValues : prevValues; but all we actually care about is whether the array changes so that unnecessary renders from state updates don't trigger.
benoitgrelard
approved these changes
Jun 22, 2021
fd490b4 to
53690a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #732