[ScrollArea] Fix forceMount type on Scrollbar
#738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forceMount typeforceMount type on Scrollbar
jjenzz
commented
Jun 22, 2021
benoitgrelard
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #728
The bug was caused because of the
ScrollAreaScrollbarVisiblepart of the union which doesn't have aforceMountprop. It looks like this was confusing the type implementation for Stitches and styled-components.It works fine without these libraries e.g.
React.ComponentProps<typeof ScrollArea.Scrollbar>reports fine but I've made this change anyway to please external libs. Not sure why they break.