Skip to content

[Checkbox][RadioGroup][Switch] Hide bubble input from SRs #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

jjenzz
Copy link
Contributor

@jjenzz jjenzz commented Sep 17, 2021

It looks like when I removed the display: none stuff from these, I forgot to hide them from SRs. Noticed while testing this radix-ui/website#240

Without this change, using the virtual cursor allows you to select the hidden input so it reads like there are two controls for SR users. Oops!

@jjenzz jjenzz merged commit 716db1d into main Sep 17, 2021
@jjenzz jjenzz deleted the bubble-input-aria-hidden branch September 17, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants