[Dialog][AlertDialog] Enable outer scrolling dialog pattern #963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #887
I'll explain the thoughts I had and what I did here:
Problem
The main issue left with being able to create an outer scrolling dialog was that we have
RemoveScroll
inDialogContent
, therefore making the overlay non-scrollable too.Thoughts and solution
DialogContentModal
)RemoveScroll
insideDialogOverlayImpl
.DialogContentModal
, so that was still preventing scrolling the overlay, for that I specifically re-enable them on the overlay.allowPinchZoom
prop as it was previously onDialogContent
. I remember almost raising this in the previous PR review that I thought perhaps it should live at the root as it's kinda an implementation detail that it was on the "content". I guess this solidified that feeling, we could have moved the prop to the overlay but it would definitely feel odd there I think.Notes for docs:
allowPinchZoom
prop is documented on the right part (Root
).