Skip to content

[Accordion] Use Collection util #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2021
Merged

[Accordion] Use Collection util #984

merged 1 commit into from
Nov 25, 2021

Conversation

jjenzz
Copy link
Contributor

@jjenzz jjenzz commented Nov 18, 2021

Adds support for asynchronously rendered items.

@jjenzz jjenzz changed the title [Accordion] Add collection [Accordion] Use Collection util Nov 18, 2021
@jjenzz jjenzz changed the title [Accordion] Use Collection util [Accordion] Use Collection util Nov 18, 2021
@jjenzz jjenzz force-pushed the accordion-collection branch 3 times, most recently from de272c1 to 1ae57ac Compare November 18, 2021 18:17
@benoitgrelard
Copy link
Contributor

Not sure why but Chromatic seems to be stuck on the previous diff (tabs)

@jjenzz jjenzz force-pushed the accordion-collection branch from 1ae57ac to 801c182 Compare November 19, 2021 11:24
Copy link
Contributor

@benoitgrelard benoitgrelard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from me apart the weird Chromatic stuff mentioned.

@jjenzz
Copy link
Contributor Author

jjenzz commented Nov 19, 2021

All good from me apart the weird Chromatic stuff mentioned.

Oh yeah, weird... I'll just approve it again and hopefully things will straighten out?

@jjenzz jjenzz merged commit e0cd53d into main Nov 25, 2021
@jjenzz jjenzz deleted the accordion-collection branch November 25, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants