Skip to content

Document latest DropdownMenu/ContextMenu changes (CheckboxItem indeterminate) #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

benoitgrelard
Copy link
Contributor

@benoitgrelard benoitgrelard commented Oct 12, 2022

radix-ui/primitives#1624

Changelog entry: b6669c8
Docs changes: 9969dd6

@vercel
Copy link

vercel bot commented Oct 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
radix-website ✅ Ready (Inspect) Visit Preview Oct 12, 2022 at 3:18PM (UTC)

@benoitgrelard benoitgrelard changed the title 1624 docs Document latest DropdownMenu/ContextMenu changes (CheckboxItem indeterminate) Oct 12, 2022
features={[
'Supports submenus with configurable reading direction.',
'Supports items, labels, groups of items.',
'Supports checkable items (single or multiple), can be indeterminate too.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we even need to mention indeterminate here or if it's already implied.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added because we have it on Checkbox

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's fair enough, in that case how'd you feel about?

Supports checkable items (single or multiple) with optional indeterminate state.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@benoitgrelard benoitgrelard merged commit 806f23e into release-eager-hurricane Oct 12, 2022
@benoitgrelard benoitgrelard deleted the 1624-docs branch October 12, 2022 16:01
benoitgrelard added a commit that referenced this pull request Oct 14, 2022
…indeterminate) (#493)

* Changelog

* Duplicate files

* Docs changes

* PR feedback
benoitgrelard added a commit that referenced this pull request Oct 17, 2022
* Initial

* Align release notes with latest changes (#468)

* Update release notes

* Create new toast page

* Document onResume, onPause toast props

* Document latest changes (#470)

* Document latest changes

* Update data/primitives/overview/releases.mdx

Co-authored-by: Andy Hook <[email protected]>

Co-authored-by: Andy Hook <[email protected]>

* Add note regarding toast timer fix (#474)

* Document latest Label changes (#475)

* Document latest Label changes

* Update copy

* Apply suggestions from code review

Co-authored-by: Andy Hook <[email protected]>

Co-authored-by: Andy Hook <[email protected]>

* Document 1693 changes (#478)

radix-ui/primitives#1693

* Latest slider updates (#480)

* Latest slider updates

radix-ui/primitives#1695

* Update data/primitives/overview/releases.mdx

Co-authored-by: Andy Hook <[email protected]>

Co-authored-by: Andy Hook <[email protected]>

* Add missing inverted prop to Slider (#482)

* Document latest changes (#481)

* Add selection improvement release note (#483)

* Document Radio Group `disabled` prop (#484)

* Create radio group file

* Add note and prop docs addition

* Add data-disabled attribute

* Document latest slider changes (#489)

* Document latest slider changes

radix-ui/primitives#1696

* Update data/primitives/components/slider/1.1.0.mdx

Co-authored-by: Andy Hook <[email protected]>

Co-authored-by: Andy Hook <[email protected]>

* [Select] Add `disabled` to API Reference (#488)

* [Select] Create docs file

* [Select] Add note and props addition

* Document latest Select changes (#490)

radix-ui/primitives#1598

* Update release note (#491)

* Latest Slots updates (#492)

* Latest Slots updates

radix-ui/primitives#1713

* Fix typo

* Document latest `DropdownMenu`/`ContextMenu` changes (`CheckboxItem` indeterminate) (#493)

* Changelog

* Duplicate files

* Docs changes

* PR feedback

* Document `NavigationMenu` delay props (#495)

* Add version page

* Documentation changes

* Update release filenames and breaking demo changes (#497)

* Tweak release note, add date

* Rename patch pages

* Rename remaining patched packages

* Bump files / versions

* Fix build

Co-authored-by: Benoît Grélard <[email protected]>
Co-authored-by: Faqih Muntashir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants