partially backported spec change of Hash#transform_keys! #833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see the commits below. ruby/ruby@31e0382 ruby/ruby@84d9a9a
eregon
reviewed
Apr 15, 2021
| @@ -84,7 +84,7 @@ | |||
| end | |||
| end | |||
|
|
|||
| ruby_version_is "2.5.1" do | |||
| ruby_version_is "2.5.1"..."3.0" do | |||
There was a problem hiding this comment.
I think it should be 3.0.1 (also below) since 3.0.0 behaves likes 2.5.1 and the result is {:b=>1, :c=>2}.
I'll push a commit to do that.
There was a problem hiding this comment.
Actually it's even 3.0.2 it seems.
There was a problem hiding this comment.
Right! Thank you for your additional fix.
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Apr 16, 2021
nagachika
added a commit
to nagachika/ruby
that referenced
this pull request
Apr 18, 2021
spec/ruby/core/hash/transform_keys_spec.rb: Fix the failure of ruby_3_0 ruby/spec#833 ruby/spec@8290e5a --- spec/ruby/core/hash/transform_keys_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
nagachika
added a commit
to nagachika/ruby
that referenced
this pull request
Apr 18, 2021
spec/ruby/core/hash/transform_keys_spec.rb: Fix the failure of ruby_3_0 ruby/spec#833 ruby/spec@8290e5a --- spec/ruby/core/hash/transform_keys_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
headius
pushed a commit
to headius/spec
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I backported the change of Hash#transform_keys! into ruby_3_0.
https://bugs.ruby-lang.org/issues/17735
This PR should stop the test-spec failures on RubyCI.
see the commits below too.
ruby/ruby@31e0382
ruby/ruby@84d9a9a