Combine some encoding files #1199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
added a commit
to ruby/ruby
that referenced
this pull request
Aug 17, 2023
This has not been relevant since ruby/prism#1199.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of the encodings that we support a single-byte encodings, we so we use a 256-byte lookup table to handle metadata checks. Almost all of the functionality is the same, except that it references different tables. Here we simplify the whole thing by putting them into the same file - you get all of the tables immediately and then creating them is very similar in almost all cases. As a bonus, this cuts down a lot on the number of source files, which means compilation times are better.