-
Notifications
You must be signed in to change notification settings - Fork 1k
paradise 2.0.0-SNAPSHOT #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@eed3si9n Macro paradise is now a compiler plugin as opposed to a custom build of scalac, which it was before. When developing the new version I've also added and removed some features. This all combined pretty much invalidates most of the docs in the macro corner of docs.scala-lang.org. Some docs need to just have their headers updated, some docs need to be trimmed of obsolete fragments. I have updated the English documentation, but unfortunately I don't know Japanese, so I couldn't apply updates to your work. In order for the stale docs in Japanese not to create confusion I took the liberty of deleting them, for which I apologize profoundly. However most of the docs need just a bit of updating (there are only two new lengthy entries - implicit macros and macro annotations), so if at some point in the future you happen to have the time to work on a fixup, it should be relatively quick. Thank you very much for your work and sorry again for deleting some of it. Please let me know if I can help in any way. |
@xeno-by Sorry about this delayed response. I had been procrastinating on updating the translation, and I completely missed this message from you in this pull req. In any case, I was able to recover the old translation from git, and I'm currently following git's history to track all the changes except for the ones that eventually got removed. So no hard feelings about the deletion. Perhaps we should work out some system in the future to lockstep the changes, like just removing the |
@eed3si9n Thanks a lot for looking into this! What would happen with a Japanese translation if I remove the "language" tag? |
@eed3si9n I would also like to apologize for not coordinating this whole business with you. I agree that commit notifications aren't very reliable. How should I try to reach you in the future? |
@xeno-by By removing the For minor updates, commit notification is fine, but I might not react to them right away since I like to batch the changes. If you have to get my input on something twitter or email should get my attention. |
For me the table of contents also works locally, but sometimes GitHub refuses to generate it correctly. Don't know why... |
"paradise 2.0.0-SNAPSHOT"
/cc @heathermiller @eed3si9n