FIX ColumnTransformer metadata routing work within another meta-estimator #28188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarManzoor
approved these changes
Feb 1, 2024
| DataFrame Support | ||
| ----------------- | ||
|
|
||
| - |Enhancement| Pandas and Polars dataframe are validated directly without ducktyping |
There was a problem hiding this comment.
Is this part of this PR?
There was a problem hiding this comment.
yes, was under the wrong section, but I had forgotten to remove the duplicate. Fixed now.
glemaitre
approved these changes
Feb 1, 2024
|
I fixed the issue with the changelog and enabling auto-merge. Thanks @adrinjalali |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 10, 2024
…ator (scikit-learn#28188) Co-authored-by: Loïc Estève <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 13, 2024
…ator (scikit-learn#28188) Co-authored-by: Loïc Estève <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
glemaitre
added a commit
that referenced
this pull request
Feb 13, 2024
…ator (#28188) Co-authored-by: Loïc Estève <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28186
The core of the issue is that
ColumnTransformer().get_metadata_request()raises if called beforefit. This fixes the issue.Note that this means all metadata requested by all given transformers are always requested, no matter whether those transformers are going to be used or not, due to column selections.