Skip to content

Commit 018293f

Browse files
authored
[py] Removing browser filter when checking shadow root. (#12122)
* [rb] Removing browser filter when checking shadow root. Only Python had it, fixes #11893 During the meeting on [25.05.2023](https://www.selenium.dev/meetings/2023/tlc-05-25/) it was decided add support for everything in spec and let the drivers error when things do not work. * [rb] Addressing PR comments
1 parent c1e47d3 commit 018293f

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

py/selenium/webdriver/remote/webelement.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -235,20 +235,12 @@ def send_keys(self, *value) -> None:
235235
@property
236236
def shadow_root(self) -> ShadowRoot:
237237
"""Returns a shadow root of the element if there is one or an error.
238-
Only works from Chromium 96 and Firefox 96 onwards. Previous versions
239-
of browsers will throw an assertion exception.
238+
Only works from Chromium 96, Firefox 96, and Safari 16.4 onwards.
240239
241240
:Returns:
242241
- ShadowRoot object or
243242
- NoSuchShadowRoot - if no shadow root was attached to element
244243
"""
245-
browser_main_version = int(self._parent.caps["browserVersion"].split(".")[0])
246-
assert (
247-
self._parent.caps["browserName"].lower() != "safari"
248-
), "This only currently works in Firefox and Chromium based browsers"
249-
assert (
250-
browser_main_version > 95
251-
), f"Please use Firefox or Chromium based browsers with version 96 or later. Version used {self._parent.caps['browserVersion']}"
252244
return self._execute(Command.GET_SHADOW_ROOT)["value"]
253245

254246
# RenderedWebElement Items

0 commit comments

Comments
 (0)