Skip to content

Commit 03f626f

Browse files
committed
[js] Expose individual test targets to Bazel
1 parent fd56c3a commit 03f626f

File tree

2 files changed

+53
-40
lines changed

2 files changed

+53
-40
lines changed

.github/workflows/ci-javascript.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,5 @@ jobs:
3939
run: >
4040
bazel test
4141
--flaky_test_attempts 3
42-
//javascript/node/selenium-webdriver:${{ matrix.browser }}-browser-tests
42+
--test_tag_filters ${{ matrix.browser }}
43+
//javascript/node/...

javascript/node/selenium-webdriver/BUILD.bazel

Lines changed: 51 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -86,17 +86,19 @@ SMALL_TESTS = [
8686
"test/net/portprober_test.js",
8787
]
8888

89+
LARGE_TESTS = glob(
90+
["test/**/*_test.js"],
91+
exclude = SMALL_TESTS,
92+
)
93+
8994
js_library(
9095
name = "small-test-srcs",
9196
srcs = SMALL_TESTS,
9297
)
9398

9499
js_library(
95100
name = "large-test-srcs",
96-
srcs = glob(
97-
["test/**/*_test.js"],
98-
exclude = SMALL_TESTS,
99-
),
101+
srcs = LARGE_TESTS,
100102
)
101103

102104
js_library(
@@ -140,41 +142,51 @@ mocha_test(
140142
)
141143

142144
[
143-
mocha_test(
144-
name = "%s-browser-tests" % browser,
145-
size = "large",
146-
args = ["--retries 1"],
147-
chdir = package_name(),
148-
data = [
149-
"test-data",
150-
":large-test-srcs",
151-
":node_modules/@bazel/runfiles",
152-
":node_modules/express",
153-
":node_modules/jszip",
154-
":node_modules/multer",
155-
":node_modules/serve-index",
156-
":node_modules/sinon",
157-
":node_modules/tmp",
158-
":node_modules/ws",
159-
"//:node_modules/selenium-webdriver",
160-
"//common/extensions:js-lib",
161-
"//common/src/web:js-lib",
162-
"//javascript/node/selenium-webdriver/lib/atoms:find-elements",
163-
"//javascript/node/selenium-webdriver/lib/atoms:get_attribute",
164-
"//javascript/node/selenium-webdriver/lib/atoms:is_displayed",
165-
"//javascript/node/selenium-webdriver/lib/atoms:mutation-listener",
166-
],
167-
env = {
168-
"SELENIUM_BROWSER": browser,
169-
},
170-
tags = [
171-
browser,
172-
"browser-test",
173-
"no-sandbox",
174-
"requires-network",
175-
"skip-remote",
176-
],
177-
)
145+
[
146+
mocha_test(
147+
name = "%s-%s" % (
148+
test.replace("/", "-").replace("_", "-"),
149+
browser,
150+
),
151+
size = "large",
152+
args = [
153+
"--retries",
154+
"1",
155+
test,
156+
],
157+
chdir = package_name(),
158+
data = [
159+
"test-data",
160+
":large-test-srcs",
161+
":node_modules/@bazel/runfiles",
162+
":node_modules/express",
163+
":node_modules/jszip",
164+
":node_modules/multer",
165+
":node_modules/serve-index",
166+
":node_modules/sinon",
167+
":node_modules/tmp",
168+
":node_modules/ws",
169+
"//:node_modules/selenium-webdriver",
170+
"//common/extensions:js-lib",
171+
"//common/src/web:js-lib",
172+
"//javascript/node/selenium-webdriver/lib/atoms:find-elements",
173+
"//javascript/node/selenium-webdriver/lib/atoms:get_attribute",
174+
"//javascript/node/selenium-webdriver/lib/atoms:is_displayed",
175+
"//javascript/node/selenium-webdriver/lib/atoms:mutation-listener",
176+
],
177+
env = {
178+
"SELENIUM_BROWSER": browser,
179+
},
180+
tags = [
181+
browser,
182+
"browser-test",
183+
"no-sandbox",
184+
"requires-network",
185+
"skip-remote",
186+
],
187+
),
188+
]
189+
for test in LARGE_TESTS
178190
for browser in [
179191
"chrome",
180192
"firefox",

0 commit comments

Comments
 (0)