[bazel] Pin chrome for testing instead of chromium

Author: shs96c

common/browsers.bzl

@@ -18,10 +18,10 @@ chromedriver_data = select({
 chrome_data = select({
     "@selenium//common:use_pinned_linux_chrome": [
         "@linux_chrome//:files",
-        "@linux_chrome//:chrome-linux/chrome",
+        "@linux_chrome//:chrome-linux64/chrome",
     ],
     "@selenium//common:use_pinned_macos_chrome": [
-        "@mac_chrome//:Chromium.app",
+        "@mac_chrome//:Chrome.app",
     ],
     "//conditions:default": [],
 }) + chromedriver_data

common/repositories.bzl

@@ -10,8 +10,8 @@ def pin_browsers():
 
     http_archive(
         name = "linux_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/113.0.2/linux-x86_64/en-US/firefox-113.0.2.tar.bz2",
-        sha256 = "5a4b4fc537d5d358c0fe416fff91692bae9b62264dabd557cf99fb6cbda91acf",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/115.0.3/linux-x86_64/en-US/firefox-115.0.3.tar.bz2",
+        sha256 = "ee8980afe907fa552b52d573073e298b7878558faff8e8d5a4a7444f4f2d2cca",
         build_file_content = """
 filegroup(
     name = "files",
@@ -27,8 +27,8 @@ exports_files(
 
     dmg_archive(
         name = "mac_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/113.0.2/mac/en-US/Firefox%20113.0.2.dmg",
-        sha256 = "48749d747b6814e90f643d401a6edf65807551902c8f2fba11de89dc728fa824",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/115.0.3/mac/en-US/Firefox%20115.0.3.dmg",
+        sha256 = "96b2616d0f95352caad756a200e0b13d20ee300be1d02fdfd3bab17ed6e73fa3",
         build_file_content = "exports_files([\"Firefox.app\"])",
     )
 
@@ -48,32 +48,32 @@ exports_files(
 
     pkg_archive(
         name = "mac_edge",
-        url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/5a7ac9fb-6410-4438-a5d1-24a16ab24157/MicrosoftEdge-113.0.1774.57.pkg",
-        sha256 = "08a84d425db829e378b558dcc0a3df41a60aa7b25ca999d8afd5ebb3c86382e5",
+        url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/1a586fcf-50fb-4714-9994-bef23c695628/MicrosoftEdge-115.0.1901.188.pkg",
+        sha256 = "c1bd8ab7e5d8972918ef089027515de14c892fb371a5b2c0322acadb46d29be8",
         move = {
-            "MicrosoftEdge-113.0.1774.57.pkg/Payload/Microsoft Edge.app": "Edge.app",
+            "MicrosoftEdge-115.0.1901.188.pkg/Payload/Microsoft Edge.app": "Edge.app",
         },
         build_file_content = "exports_files([\"Edge.app\"])",
     )
 
     http_archive(
         name = "linux_edgedriver",
-        url = "https://msedgedriver.azureedge.net/113.0.1774.57/edgedriver_linux64.zip",
-        sha256 = "d6992f54c711c1042256b2ab10a0b1054e30222e01484fc068857bee72329adb",
+        url = "https://msedgedriver.azureedge.net/115.0.1901.188/edgedriver_linux64.zip",
+        sha256 = "8a5d10f0d6c43ecf1c6c503a301defcf648a46440c32437862add99839bc4446",
         build_file_content = "exports_files([\"msedgedriver\"])",
     )
 
     http_archive(
         name = "mac_edgedriver",
-        url = "https://msedgedriver.azureedge.net/113.0.1774.57/edgedriver_mac64.zip",
-        sha256 = "299b53816807c70498020d05fe18e442627a40a0f987df87702b3089eb93d6af",
+        url = "https://msedgedriver.azureedge.net/115.0.1901.188/edgedriver_mac64.zip",
+        sha256 = "934fdf4f620cba11ba039e8e7dc40a7e23d0a49b5896e5ba53f3be1fe7b4e6ef",
         build_file_content = "exports_files([\"msedgedriver\"])",
     )
 
     http_archive(
         name = "linux_chrome",
-        url = "https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1135542/chrome-linux.zip",
-        sha256 = "2f81ebe4389d7ca6f4e0b9b4065b87e163a94f710a12cef77033c4cb90b8be94",
+        url = "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5790.102/linux64/chrome-linux64.zip",
+        sha256 = "aebaecf70965f152a743935a95d0013de3e9d96e194106eb13dfc1b9b1c7892c",
         build_file_content = """
 filegroup(
     name = "files",
@@ -82,17 +82,21 @@ filegroup(
 )
 
 exports_files(
-    ["chrome-linux/chrome"],
+    ["chrome-linux64/chrome"],
 )
 """,
     )
 
     http_archive(
         name = "mac_chrome",
-        url = "https://storage.googleapis.com/chromium-browser-snapshots/Mac/1135542/chrome-mac.zip",
-        sha256 = "9a3b8c4d26028bb0bfaea5176703c093a812d36f93dd2c5b795d5addc6c4ce2d",
-        strip_prefix = "chrome-mac",
-        build_file_content = "exports_files([\"Chromium.app\"])",
+        url = "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5790.102/mac-x64/chrome-mac-x64.zip",
+        sha256 = "76e2fbb782e195259e7e7873ffca0e7270d52066af79a0d401c92d66382420ec",
+        strip_prefix = "chrome-mac-x64",
+        patch_cmds = [
+            "mv 'Google Chrome for Testing.app' Chrome.app",
+            "mv 'Chrome.app/Contents/MacOS/Google Chrome for Testing' Chrome.app/Contents/MacOS/Chrome",
+        ],
+        build_file_content = "exports_files([\"Chrome.app\"])",
     )
 
     http_archive(

java/browsers.bzl

@@ -10,10 +10,10 @@ chromedriver_jvm_flags = select({
 
 chrome_jvm_flags = select({
     "@selenium//common:use_pinned_linux_chrome": [
-        "-Dwebdriver.chrome.binary=$(location @linux_chrome//:chrome-linux/chrome)",
+        "-Dwebdriver.chrome.binary=$(location @linux_chrome//:chrome-linux64/chrome)",
     ],
     "@selenium//common:use_pinned_macos_chrome": [
-        "-Dwebdriver.chrome.binary=$(location @mac_chrome//:Chromium.app)/Contents/MacOS/Chromium",
+        "-Dwebdriver.chrome.binary=$(location @mac_chrome//:Chrome.app)/Contents/MacOS/Chrome",
     ],
     "@selenium//common:use_local_chromedriver": [],
     "//conditions:default": [

java/src/org/openqa/selenium/grid/BUILD.bazel

@@ -32,13 +32,13 @@ java_binary(
     name = "pinned-grid",
     data = select({
         "//common:linux": [
-            "@linux_chrome//:chrome-linux/chrome",
+            "@linux_chrome//:chrome-linux64/chrome",
             "@linux_chromedriver//:chromedriver",
             "@linux_firefox//:firefox/firefox",
             "@linux_geckodriver//:geckodriver",
         ],
         "//common:macos": [
-            "@mac_chrome//:Chromium.app",
+            "@mac_chrome//:Chrome.app",
             "@mac_chromedriver//:chromedriver",
             "@mac_firefox//:Firefox.app",
             "@mac_geckodriver//:geckodriver",
@@ -48,13 +48,13 @@ java_binary(
     jvm_flags = select({
         "//common:linux": [
             "-Dwebdriver.chrome.driver=$(location @linux_chromedriver//:chromedriver)",
-            "-Dwebdriver.chrome.binary=$(location @linux_chrome//:chrome-linux/chrome)",
+            "-Dwebdriver.chrome.binary=$(location @linux_chrome//:chrome-linux64/chrome)",
             "-Dwebdriver.gecko.driver=$(location @linux_geckodriver//:geckodriver)",
             "-Dwebdriver.firefox.bin=$(location @linux_firefox//:firefox/firefox)",
         ],
         "//common:macos": [
             "-Dwebdriver.chrome.driver=$(location @mac_chromedriver//:chromedriver)",
-            "-Dwebdriver.chrome.binary=$(location @mac_chrome//:Chromium.app)/Contents/MacOS/Chromium",
+            "-Dwebdriver.chrome.binary=$(location @mac_chrome//:Chrome.app)/Contents/MacOS/Chrome",
             "-Dwebdriver.gecko.driver=$(location @mac_geckodriver//:geckodriver)",
             "-Dwebdriver.firefox.bin=$(location @mac_firefox//:Firefox.app)/Contents/MacOS/firefox",
         ],

py/private/browsers.bzl

@@ -16,13 +16,13 @@ headless_args = select({
 chrome_args = select({
     "@selenium//common:use_pinned_linux_chrome": [
         "--driver-binary=$(location @linux_chromedriver//:chromedriver)",
-        "--browser-binary=$(location @linux_chrome//:chrome-linux/chrome)",
+        "--browser-binary=$(location @linux_chrome//:chrome-linux64/chrome)",
         "--browser-args=--disable-dev-shm-usage",
         "--browser-args=--no-sandbox",
     ],
     "@selenium//common:use_pinned_macos_chrome": [
         "--driver-binary=$(location @mac_chromedriver//:chromedriver)",
-        "--browser-binary=$(location @mac_chrome//:Chromium.app)/Contents/MacOS/Chromium",
+        "--browser-binary=$(location @mac_chrome//:Chrome.app)/Contents/MacOS/Chrome",
     ],
     "@selenium//common:use_local_chromedriver": [
         "--driver-binary=$(location @selenium//common:chromedriver)",

scripts/BUILD.bazel

@@ -5,6 +5,7 @@ py_binary(
     name = "pinned_browsers",
     srcs = ["pinned_browsers.py"],
     deps = [
+        requirement("packaging"),
         requirement("urllib3"),
     ],
 )

scripts/pinned_browsers.py

@@ -4,6 +4,8 @@
 import json
 import urllib3
 
+from packaging.version import LegacyVersion
+
 # Find the current stable versions of each browser we
 # support and the sha256 of these. That's useful for
 # updating `//common:repositories.bzl`
@@ -47,31 +49,24 @@ def chromedriver():
     return content
 
 def chrome():
-    # Find the current latest stable revision
-    r = http.request('GET', 'https://omahaproxy.appspot.com/all.json?channel=stable&os=linux')
-    max_version = int(json.loads(r.data)[0]['versions'][0]['branch_base_position'])
-    min_version = max_version - 1500
-
-    # count down from most recent to a version which has something for everyone
-    for v in range(max_version, min_version, -1):
-        r = http.request(
-            'HEAD',
-            'https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/%s/chrome-linux.zip' % v)
-        if r.status != 200:
-            continue
+    channel = "Stable"
+    r = http.request('GET', f'https://chromiumdash.appspot.com/fetch_releases?channel={channel}&num=1&platform=Win32,Windows,Mac,Linux')
+    milestone = json.loads(r.data)[0]["milestone"]
 
-        r = http.request(
-            'HEAD',
-            'https://storage.googleapis.com/chromium-browser-snapshots/Mac/%s/chrome-mac.zip' % v)
-        if r.status != 200:
-            continue
+    r = http.request('GET', 'https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json')
+    versions = json.loads(r.data)["versions"]
+
+    selected_version = sorted(
+        filter(lambda v: v['version'].split('.')[0] == str(milestone), versions),
+        key=lambda v: LegacyVersion(v['version'])
+    )[-1]
 
-        content = ""
+    downloads = selected_version["downloads"]["chrome"]
 
-        linux = 'https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/%s/chrome-linux.zip' % v
-        sha = calculate_hash(linux)
+    linux = [d["url"] for d in downloads if d["platform"] == "linux64"][0]
+    sha = calculate_hash(linux)
 
-        content = content + """
+    content = """
     http_archive(
         name = "linux_chrome",
         url = "%s",
@@ -84,27 +79,32 @@ def chrome():
 )
 
 exports_files(
-    ["chrome-linux/chrome"],
+    ["chrome-linux64/chrome"],
 )
 \"\"\",
     )
-    """ % (linux, sha)
 
-        mac = 'https://storage.googleapis.com/chromium-browser-snapshots/Mac/%s/chrome-mac.zip' % v
-        sha = calculate_hash(mac)
+""" % (linux, sha)
+
+    mac = [d["url"] for d in downloads if d["platform"] == "mac-x64"][0]
+    sha = calculate_hash(mac)
 
-        content = content + """
+    content += """
     http_archive(
         name = "mac_chrome",
         url = "%s",
         sha256 = "%s",
-        strip_prefix = "chrome-mac",
-        build_file_content = "exports_files([\\"Chromium.app\\"])",
+        strip_prefix = "chrome-mac-x64",
+        patch_cmds = [
+            "mv 'Google Chrome for Testing.app' Chrome.app",
+            "mv 'Chrome.app/Contents/MacOS/Google Chrome for Testing' Chrome.app/Contents/MacOS/Chrome",
+        ],
+        build_file_content = "exports_files([\\"Google Chrome for Testing.app\\"])",
     )
-    """ % (mac, sha)
 
-        return content
-    raise RuntimeError("Cannot find stable chrome")
+""" % (mac, sha)
+
+    return content
 
 def edge():
     r = http.request('GET', 'https://edgeupdates.microsoft.com/api/products')
@@ -226,7 +226,8 @@ def firefox():
 )
 \"\"\",
     )
-    """ % (linux, sha)
+
+""" % (linux, sha)
 
     mac = "https://ftp.mozilla.org/pub/firefox/releases/%s/mac/en-US/Firefox%%20%s.dmg" % (v, v)
     sha = calculate_hash(mac)
@@ -237,7 +238,8 @@ def firefox():
         sha256 = "%s",
         build_file_content = "exports_files([\\"Firefox.app\\"])",
     )
-    """ % (mac, sha)
+
+""" % (mac, sha)
 
     return content