Skip to content

Commit 0cceb8a

Browse files
authored
[java] close the CDP connection on quit for FF (#11109)
close the CDP connection on quit for FF The FirefoxDriver did not close the CDP connection on quit like the ChromiumDriver does. [skip ci]
1 parent 9e91560 commit 0cceb8a

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

java/src/org/openqa/selenium/firefox/FirefoxDriver.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ public class FirefoxDriver extends RemoteWebDriver
8888
private final Optional<URI> cdpUri;
8989
private final Optional<URI> biDiUri;
9090
protected FirefoxBinary binary;
91+
private Connection connection;
9192
private DevTools devTools;
9293
private BiDi biDi;
9394
public FirefoxDriver() {
@@ -246,7 +247,7 @@ public Optional<DevTools> maybeGetDevTools() {
246247
ClientConfig wsConfig = ClientConfig.defaultConfig().baseUri(wsUri);
247248
HttpClient wsClient = clientFactory.createClient(wsConfig);
248249

249-
Connection connection = new Connection(wsClient, wsUri.toString());
250+
connection = new Connection(wsClient, wsUri.toString());
250251
CdpInfo cdpInfo = new CdpVersionFinder().match("85.0").orElseGet(NoOpCdpInfo::new);
251252
devTools = new DevTools(cdpInfo::getDomains, connection);
252253

@@ -298,6 +299,14 @@ public BiDi getBiDi() {
298299
.orElseThrow(() -> new DevToolsException("Unable to initialize Bidi connection"));
299300
}
300301

302+
@Override
303+
public void quit() {
304+
if (connection != null) {
305+
connection.close();
306+
}
307+
super.quit();
308+
}
309+
301310
public static final class SystemProperty {
302311

303312
/**

0 commit comments

Comments
 (0)