Skip to content

Commit 12d92aa

Browse files
DrMarcIIlukeis
authored andcommitted
GeckoDriverService always launches GeckoDriver. (#2808)
GeckoDriver can find Firefox using its own logic (either on the PATH or specified in a capability).
1 parent 0fce43e commit 12d92aa

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

java/client/src/org/openqa/selenium/firefox/GeckoDriverService.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,14 @@ protected ImmutableList<String> createArgs() {
101101
if (getLogFile() != null) {
102102
argsBuilder.add(String.format("--log-file=\"%s\"", getLogFile().getAbsolutePath()));
103103
}
104-
argsBuilder.add("-b");
105-
argsBuilder.add(new Executable(null).getPath());
104+
try {
105+
Executable firefoxExe = new Executable(null);
106+
argsBuilder.add("-b");
107+
argsBuilder.add(firefoxExe.getPath());
108+
} catch (WebDriverException e) {
109+
// Unable to find Firefox. GeckoDriver will be responsible for finding
110+
// Firefox on the PATH or via a capability.
111+
}
106112
return argsBuilder.build();
107113
}
108114

0 commit comments

Comments
 (0)