Skip to content

Commit 134cbc2

Browse files
committed
rb - minor options tidying
1 parent 7cefa09 commit 134cbc2

File tree

4 files changed

+3
-11
lines changed

4 files changed

+3
-11
lines changed

rb/lib/selenium/webdriver/chrome/bridge.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ def create_capabilities(opts)
8484

8585
caps[:chrome_options] = chrome_options
8686
caps[:proxy] = opts.delete(:proxy) if opts.key?(:proxy)
87+
caps[:proxy] ||= opts.delete('proxy') if opts.key?('proxy')
8788

8889
caps
8990
end

rb/lib/selenium/webdriver/common/driver.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def for(browser, opts = {})
4444
listener = opts.delete(:listener)
4545

4646
bridge = case browser
47-
when :firefox, :ff, :marionette
47+
when :firefox, :ff
4848
if Remote::W3CCapabilities.w3c?(opts)
4949
Firefox::W3CBridge.new(opts)
5050
else

rb/lib/selenium/webdriver/edge.rb

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,6 @@ def self.driver_path
4545
path
4646
end
4747
end
48-
49-
def self.path=(path)
50-
Platform.assert_executable path
51-
@path = path
52-
end
53-
54-
def self.path
55-
@path ||= nil
56-
end
5748
end # Edge
5849
end # WebDriver
5950
end # Selenium

rb/lib/selenium/webdriver/safari/apple_bridge.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def quit
4343
private
4444

4545
def extract_service_args(args = {})
46-
["–host=#{args[:port]}"] if args.key? :port
46+
args.key?(:port) ? ["--port=#{args[:port]}"] : []
4747
end
4848
end # AppleBridge
4949
end # Safari

0 commit comments

Comments
 (0)