Skip to content

Commit 1aa091e

Browse files
committed
[dotnet] Run Edge tests on RBE
1 parent 4b584ef commit 1aa091e

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

.skipped-tests

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
-//dotnet/test/common:DevTools/DevToolsNetworkTest-chrome
22
-//dotnet/test/common:Interactions/BasicMouseInterfaceTest-chrome
3+
-//dotnet/test/common:Interactions/BasicMouseInterfaceTest-edge
34
-//dotnet/test/common:Interactions/BasicMouseInterfaceTest-firefox
45
-//dotnet/test/common:JavascriptEnabledBrowserTest-chrome
56
-//dotnet/test/common:NetworkInterceptionTests-chrome
@@ -29,6 +30,7 @@
2930
-//java/test/org/openqa/selenium/remote:RemoteWebDriverBuilderTest
3031
-//java/test/org/openqa/selenium/remote:RemoteWebDriverScreenshotTest-remote
3132
-//javascript/atoms:test-chrome
33+
-//javascript/atoms:test-edge
3234
-//javascript/atoms:test-firefox-beta
3335
-//javascript/atoms:test-firefox-dev
3436
-//py:common-chrome-test/selenium/webdriver/common/virtual_authenticator_tests.py

dotnet/private/dotnet_nunit_test_suite.bzl

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@ _BROWSERS = {
3232
"args": [
3333
"--params=ActiveDriverConfig=Edge",
3434
] + select({
35+
"@selenium//common:use_pinned_linux_edge": [
36+
"--params=DriverServiceLocation=$(location @linux_edgedriver//:msedgedriver)",
37+
"--params=BrowserLocation=$(location @linux_edge//:opt/microsoft/msedge/microsoft-edge)",
38+
],
3539
"@selenium//common:use_pinned_macos_edge": [
3640
"--params=DriverServiceLocation=$(location @mac_edgedriver//:msedgedriver)",
3741
"\"--params=BrowserLocation=$(location @mac_edge//:Edge.app)/Contents/MacOS/Microsoft Edge\"",
@@ -42,7 +46,7 @@ _BROWSERS = {
4246
],
4347
}),
4448
"data": edge_data,
45-
"tags": ["skip-remote"],
49+
"tags": [],
4650
},
4751
"firefox": {
4852
"args": [

dotnet/test/common/Environment/DriverFactory.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,10 @@ public IWebDriver CreateDriverWithOptions(Type driverType, DriverOptions driverO
8787
{
8888
browser = Browser.Edge;
8989
options = GetDriverOptions<EdgeOptions>(driverType, driverOptions);
90+
91+
var edgeOptions = (EdgeOptions)options;
92+
edgeOptions.AddArguments("--no-sandbox", "--disable-dev-shm-usage");
93+
9094
service = CreateService<EdgeDriverService>();
9195
if (!string.IsNullOrEmpty(this.browserBinaryLocation))
9296
{

0 commit comments

Comments
 (0)