Skip to content

Commit 1cd3276

Browse files
committed
[java] Simplifying code and deleting unused methods of an internal class
1 parent e76105b commit 1cd3276

File tree

1 file changed

+4
-19
lines changed

1 file changed

+4
-19
lines changed

java/client/src/org/openqa/selenium/firefox/Preferences.java

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -96,24 +96,17 @@ private void readDefaultPreferences(Reader defaultsReader) {
9696
Map<String, Object> map = new Json().toType(rawJson, MAP_TYPE);
9797

9898
Map<String, Object> frozen = (Map<String, Object>) map.get("frozen");
99-
for (Map.Entry<String, Object> entry : frozen.entrySet()) {
100-
String key = entry.getKey();
101-
Object value = entry.getValue();
99+
frozen.forEach((key, value) -> {
102100
if (value instanceof Long) {
103101
value = ((Long) value).intValue();
104102
}
105103
setPreference(key, value);
106104
immutablePrefs.put(key, value);
107-
}
105+
});
108106

109107
Map<String, Object> mutable = (Map<String, Object>) map.get("mutable");
110-
for (Map.Entry<String, Object> entry : mutable.entrySet()) {
111-
Object value = entry.getValue();
112-
if (value instanceof Long) {
113-
value = ((Long) value).intValue();
114-
}
115-
setPreference(entry.getKey(), value);
116-
}
108+
mutable.forEach(this::setPreference);
109+
117110
} catch (IOException e) {
118111
throw new WebDriverException(e);
119112
}
@@ -163,10 +156,6 @@ public void addTo(Preferences prefs) {
163156
prefs.allPrefs.putAll(allPrefs);
164157
}
165158

166-
public void addTo(FirefoxProfile profile) {
167-
profile.getAdditionalPreferences().allPrefs.putAll(allPrefs);
168-
}
169-
170159
public void writeTo(Writer writer) throws IOException {
171160
for (Map.Entry<String, Object> pref : allPrefs.entrySet()) {
172161
writer.append("user_pref(\"").append(pref.getKey()).append("\", ");
@@ -213,10 +202,6 @@ private boolean isStringified(String value) {
213202
return value.startsWith("\"") && value.endsWith("\"");
214203
}
215204

216-
public void putAll(Map<String, Object> frozenPreferences) {
217-
allPrefs.putAll(frozenPreferences);
218-
}
219-
220205
void checkForChangesInFrozenPreferences() {
221206
allPrefs.forEach((this::checkPreference));
222207
}

0 commit comments

Comments
 (0)