Skip to content

Commit 20fb45b

Browse files
authored
[rust] Bug-fix: condition to check stable label (#12472)
[rust] Fix condition to check stable label
1 parent 2dfa139 commit 20fb45b

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

rust/src/lib.rs

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -254,36 +254,37 @@ pub trait SeleniumManager {
254254
// First, we try to discover the browser version
255255
if !download_browser {
256256
match self.discover_browser_version() {
257-
Some(version) => {
257+
Some(discovered_version) => {
258258
if !self.is_safari() {
259259
self.get_logger().debug(format!(
260260
"Detected browser: {} {}",
261261
self.get_browser_name(),
262-
version
262+
discovered_version
263263
));
264264
}
265-
let discovered_major_browser_version =
266-
self.get_major_version(&version).unwrap_or_default();
265+
let discovered_major_browser_version = self
266+
.get_major_version(&discovered_version)
267+
.unwrap_or_default();
267268

268269
if self.is_browser_version_stable() {
269270
let online_browser_version = self.request_browser_version()?;
270271
if online_browser_version.is_some() {
271272
let major_online_browser_version =
272273
self.get_major_version(&online_browser_version.unwrap())?;
273-
if major_browser_version.eq(&major_online_browser_version) {
274+
if discovered_major_browser_version.eq(&major_online_browser_version) {
274275
self.get_logger().debug(format!(
275-
"Online stable browser version ({}) different to specified browser version ({})",
276-
major_online_browser_version,
277-
major_browser_version,
276+
"Online stable {} version ({}) is the same as the one installed in the system",
277+
self.get_browser_name(),
278+
discovered_major_browser_version,
278279
));
279-
download_browser = true;
280+
self.set_browser_version(discovered_version);
280281
} else {
281282
self.get_logger().debug(format!(
282-
"Online stable {} version ({}) is the same as the one installed in the system",
283-
self.get_browser_name(),
283+
"Online stable browser version ({}) different to detected browser version ({})",
284284
major_online_browser_version,
285+
discovered_major_browser_version,
285286
));
286-
self.set_browser_version(version);
287+
download_browser = true;
287288
}
288289
}
289290
} else if !major_browser_version.is_empty()
@@ -297,7 +298,7 @@ pub trait SeleniumManager {
297298
));
298299
download_browser = true;
299300
} else {
300-
self.set_browser_version(version);
301+
self.set_browser_version(discovered_version);
301302
}
302303
}
303304
None => {

0 commit comments

Comments
 (0)