@@ -254,36 +254,37 @@ pub trait SeleniumManager {
254
254
// First, we try to discover the browser version
255
255
if !download_browser {
256
256
match self . discover_browser_version ( ) {
257
- Some ( version ) => {
257
+ Some ( discovered_version ) => {
258
258
if !self . is_safari ( ) {
259
259
self . get_logger ( ) . debug ( format ! (
260
260
"Detected browser: {} {}" ,
261
261
self . get_browser_name( ) ,
262
- version
262
+ discovered_version
263
263
) ) ;
264
264
}
265
- let discovered_major_browser_version =
266
- self . get_major_version ( & version) . unwrap_or_default ( ) ;
265
+ let discovered_major_browser_version = self
266
+ . get_major_version ( & discovered_version)
267
+ . unwrap_or_default ( ) ;
267
268
268
269
if self . is_browser_version_stable ( ) {
269
270
let online_browser_version = self . request_browser_version ( ) ?;
270
271
if online_browser_version. is_some ( ) {
271
272
let major_online_browser_version =
272
273
self . get_major_version ( & online_browser_version. unwrap ( ) ) ?;
273
- if major_browser_version . eq ( & major_online_browser_version) {
274
+ if discovered_major_browser_version . eq ( & major_online_browser_version) {
274
275
self . get_logger ( ) . debug ( format ! (
275
- "Online stable browser version ({}) different to specified browser version ({}) " ,
276
- major_online_browser_version ,
277
- major_browser_version ,
276
+ "Online stable {} version ({}) is the same as the one installed in the system " ,
277
+ self . get_browser_name ( ) ,
278
+ discovered_major_browser_version ,
278
279
) ) ;
279
- download_browser = true ;
280
+ self . set_browser_version ( discovered_version ) ;
280
281
} else {
281
282
self . get_logger ( ) . debug ( format ! (
282
- "Online stable {} version ({}) is the same as the one installed in the system" ,
283
- self . get_browser_name( ) ,
283
+ "Online stable browser version ({}) different to detected browser version ({})" ,
284
284
major_online_browser_version,
285
+ discovered_major_browser_version,
285
286
) ) ;
286
- self . set_browser_version ( version ) ;
287
+ download_browser = true ;
287
288
}
288
289
}
289
290
} else if !major_browser_version. is_empty ( )
@@ -297,7 +298,7 @@ pub trait SeleniumManager {
297
298
) ) ;
298
299
download_browser = true ;
299
300
} else {
300
- self . set_browser_version ( version ) ;
301
+ self . set_browser_version ( discovered_version ) ;
301
302
}
302
303
}
303
304
None => {
0 commit comments