Skip to content

Commit 212a5e7

Browse files
committed
Don't use js_binary to copy the safari driver client. Buck/crazy-fun's
implementation re-adds the closure base library, which we don't need. (#2277)
1 parent 51938c4 commit 212a5e7

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

javascript/node/selenium-webdriver/safari.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ const portprober = require('./net/portprober');
5252
/** @const */
5353
const CLIENT_PATH = isDevMode
5454
? path.join(__dirname,
55-
'../../../build/javascript/safari-driver/client.js')
55+
'../../../buck-out/gen/javascript/safari-driver/client.js')
5656
: path.join(__dirname, 'lib/safari/client.js');
5757

5858

javascript/safari-driver/BUCK

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
js_binary(name = 'client',
2-
srcs = ['client.js'],
3-
flags = [
4-
'--compilation_level=WHITESPACE_ONLY',
5-
],
1+
2+
export_file(
3+
name = 'client',
4+
src = 'client.js',
5+
out = 'client.js',
66
visibility = [
77
'//java/client/src/org/openqa/selenium/safari:client',
88
],

javascript/safari-driver/build.desc

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
# This is a snapshot generated from the same target in the safari branch.
2-
js_binary(
2+
# We don't actually need it renamed, but we do want it copied to build
3+
# output.
4+
rename(
35
name = "client",
46
srcs = ["client.js"],
5-
flags = [
6-
"--compilation_level=WHITESPACE_ONLY",
7-
])
7+
out = "client.js
8+
)

0 commit comments

Comments
 (0)