Skip to content

Commit 2f6f60f

Browse files
jimevanssfdcjimevanssfdc
committed
Unignoring tests for Safari on .NET
Note carefully this does not mean the tests will pass. It merely means that the test suite can now be run to completion without hanging the driver.
1 parent 1d603d5 commit 2f6f60f

23 files changed

+39
-81
lines changed

‎dotnet/test/common/AvailableLogsTest.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ namespace OpenQA.Selenium
1010
[IgnoreBrowser(Browser.IE, "IE driver does not support logs API")]
1111
[IgnoreBrowser(Browser.Edge, "Edge driver does not support logs API")]
1212
[IgnoreBrowser(Browser.PhantomJS, "PhantomJS driver does not support logs API")]
13-
public class AvailableLogsTest : DriverTestFixture
13+
[IgnoreBrowser(Browser.Safari, "Edge driver does not support logs API")]
14+
public class AvailableLogsTest : DriverTestFixture
1415
{
1516
private IWebDriver localDriver;
1617

‎dotnet/test/common/ClickScrollingTest.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ public void ShouldNotScrollOverflowElementsWhichAreVisible()
9090
[Test]
9191
[IgnoreBrowser(Browser.Chrome, "Webkit-based browsers apparently scroll anyway.")]
9292
[IgnoreBrowser(Browser.IPhone, "Webkit-based browsers apparently scroll anyway.")]
93-
[IgnoreBrowser(Browser.Safari, "Webkit-based browsers apparently scroll anyway.")]
9493
[IgnoreBrowser(Browser.PhantomJS, "Webkit-based browsers apparently scroll anyway.")]
9594
public void ShouldNotScrollIfAlreadyScrolledAndElementIsInView()
9695
{
@@ -121,7 +120,6 @@ public void ShouldScrollOverflowElementsIfClickPointIsOutOfViewButElementIsInVie
121120
[Test]
122121
[IgnoreBrowser(Browser.Opera, "Opera fails.")]
123122
[IgnoreBrowser(Browser.IPhone, "Not tested.")]
124-
[IgnoreBrowser(Browser.Safari, "Not tested.")]
125123
public void ShouldBeAbleToClickElementInAFrameThatIsOutOfView()
126124
{
127125
try
@@ -141,7 +139,6 @@ public void ShouldBeAbleToClickElementInAFrameThatIsOutOfView()
141139
[Test]
142140
[IgnoreBrowser(Browser.Opera, "Opera fails.")]
143141
[IgnoreBrowser(Browser.IPhone, "Not tested.")]
144-
[IgnoreBrowser(Browser.Safari, "Not tested.")]
145142
public void ShouldBeAbleToClickElementThatIsOutOfViewInAFrame()
146143
{
147144
try
@@ -178,7 +175,6 @@ public void ShouldNotBeAbleToClickElementThatIsOutOfViewInANonScrollableFrame()
178175
[Test]
179176
[IgnoreBrowser(Browser.Opera, "Opera fails.")]
180177
[IgnoreBrowser(Browser.IPhone, "Not tested.")]
181-
[IgnoreBrowser(Browser.Safari, "Not tested.")]
182178
public void ShouldBeAbleToClickElementThatIsOutOfViewInAFrameThatIsOutOfView()
183179
{
184180
try
@@ -198,7 +194,6 @@ public void ShouldBeAbleToClickElementThatIsOutOfViewInAFrameThatIsOutOfView()
198194
[Test]
199195
[IgnoreBrowser(Browser.Opera, "Opera fails.")]
200196
[IgnoreBrowser(Browser.IPhone, "Not tested.")]
201-
[IgnoreBrowser(Browser.Safari, "Not tested.")]
202197
public void ShouldBeAbleToClickElementThatIsOutOfViewInANestedFrame()
203198
{
204199
try
@@ -219,7 +214,6 @@ public void ShouldBeAbleToClickElementThatIsOutOfViewInANestedFrame()
219214
[Test]
220215
[IgnoreBrowser(Browser.Opera, "Opera fails.")]
221216
[IgnoreBrowser(Browser.IPhone, "Not tested.")]
222-
[IgnoreBrowser(Browser.Safari, "Not tested.")]
223217
public void ShouldBeAbleToClickElementThatIsOutOfViewInANestedFrameThatIsOutOfView()
224218
{
225219
try

‎dotnet/test/common/ClickTest.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ public void ShouldSetRelatedTargetForMouseOver()
145145
[IgnoreBrowser(Browser.IPhone, "Doesn't support multiple windows")]
146146
[IgnoreBrowser(Browser.WindowsPhone, "Doesn't support multiple windows")]
147147
[IgnoreBrowser(Browser.Opera, "Doesn't support multiple windows")]
148-
[IgnoreBrowser(Browser.Safari, "Doesn't support multiple windows; Safari: issue 3693")]
149148
[IgnoreBrowser(Browser.Edge, "Hangs browser")]
150149
public void ShouldOnlyFollowHrefOnce()
151150
{
@@ -364,7 +363,6 @@ public void ShouldBeAbleToClickOnASpanThatWrapsToTheNextLine()
364363
[Test]
365364
[IgnoreBrowser(Browser.IE)]
366365
[IgnoreBrowser(Browser.Chrome)]
367-
[IgnoreBrowser(Browser.Safari)]
368366
public void ShouldBeAbleToClickOnAPartiallyOverlappedLinkThatWrapsToTheNextLine()
369367
{
370368
driver.Url = EnvironmentManager.Instance.UrlBuilder.WhereIs("click_tests/wrapped_overlapping_elements.html");

‎dotnet/test/common/CookieImplementationTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
namespace OpenQA.Selenium
1010
{
1111
[TestFixture]
12-
[IgnoreBrowser(Browser.Safari)]
1312
public class CookieImplementationTest : DriverTestFixture
1413
{
1514
private Random random = new Random();

‎dotnet/test/common/CorrectEventFiringTest.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,6 @@ public void SubmittingFormFromFormInputTextElementShouldFireOnSubmitForThatFormA
328328

329329
[Test]
330330
[Category("Javascript")]
331-
[IgnoreBrowser(Browser.Safari, "Does not yet support file uploads")]
332331
[IgnoreBrowser(Browser.WindowsPhone, "Does not yet support file uploads")]
333332
public void UploadingFileShouldFireOnChangeEvent()
334333
{
@@ -381,7 +380,6 @@ public void ClickEventsShouldBubble()
381380

382381
[Test]
383382
[IgnoreBrowser(Browser.IE, "IE doesn't support detecting overlapped elements")]
384-
[IgnoreBrowser(Browser.Safari)]
385383
public void ClickOverlappingElements()
386384
{
387385
if (TestUtilities.IsOldIE(driver))
@@ -397,7 +395,6 @@ public void ClickOverlappingElements()
397395
[Test]
398396
[IgnoreBrowser(Browser.IE, "IE doesn't support detecting overlapped elements")]
399397
[IgnoreBrowser(Browser.Chrome)]
400-
[IgnoreBrowser(Browser.Safari)]
401398
public void ClickPartiallyOverlappingElements()
402399
{
403400
if (TestUtilities.IsOldIE(driver))
@@ -450,7 +447,6 @@ public void NativelyClickOverlappingElements()
450447
}
451448

452449
[Test]
453-
[IgnoreBrowser(Browser.Safari)]
454450
public void ClickAnElementThatDisappear()
455451
{
456452
if (TestUtilities.IsOldIE(driver))

‎dotnet/test/common/DriverDisposalTest.cs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ namespace OpenQA.Selenium
88
public class DriverDisposalTest : DriverTestFixture
99
{
1010
[Test]
11-
[IgnoreBrowser(Browser.Safari)]
1211
public void ShouldOpenAndCloseBrowserRepeatedly()
1312
{
1413
for (int i = 0; i < 5; i++)
@@ -22,7 +21,6 @@ public void ShouldOpenAndCloseBrowserRepeatedly()
2221

2322
[Test]
2423
[NeedsFreshDriver(IsCreatedAfterTest = true)]
25-
[IgnoreBrowser(Browser.Safari)]
2624
public void ShouldBeAbleToStartNewDriverAfterCallingCloseOnOnlyOpenWindow()
2725
{
2826
EnvironmentManager.Instance.CloseCurrentDriver();
@@ -39,7 +37,6 @@ public void ShouldBeAbleToStartNewDriverAfterCallingCloseOnOnlyOpenWindow()
3937

4038
[Test]
4139
[NeedsFreshDriver(IsCreatedAfterTest = true)]
42-
[IgnoreBrowser(Browser.Safari)]
4340
public void ShouldBeAbleToCallQuitAfterCallingCloseOnOnlyOpenWindow()
4441
{
4542
EnvironmentManager.Instance.CloseCurrentDriver();
@@ -55,7 +52,6 @@ public void ShouldBeAbleToCallQuitAfterCallingCloseOnOnlyOpenWindow()
5552

5653
[Test]
5754
[NeedsFreshDriver(IsCreatedAfterTest = true)]
58-
[IgnoreBrowser(Browser.Safari)]
5955
public void ShouldBeAbleToCallDisposeAfterQuit()
6056
{
6157
EnvironmentManager.Instance.CloseCurrentDriver();
@@ -71,7 +67,6 @@ public void ShouldBeAbleToCallDisposeAfterQuit()
7167

7268
[Test]
7369
[IgnoreBrowser(Browser.Firefox, "Firefox doesn't shut its server down immediately upon calling Close(), so a subsequent call could succeed.")]
74-
[IgnoreBrowser(Browser.Safari)]
7570
[NeedsFreshDriver(IsCreatedAfterTest = true)]
7671
public void ShouldNotBeAbleToCallDriverMethodAfterCallingCloseOnOnlyOpenWindow()
7772
{
@@ -99,7 +94,6 @@ public void ShouldNotBeAbleToCallDriverMethodAfterCallingCloseOnOnlyOpenWindow()
9994

10095
[Test]
10196
[NeedsFreshDriver(IsCreatedAfterTest = true)]
102-
[IgnoreBrowser(Browser.Safari)]
10397
public void ShouldNotBeAbleToCallDriverMethodAfterCallingQuit()
10498
{
10599
EnvironmentManager.Instance.CloseCurrentDriver();
@@ -123,7 +117,6 @@ public void ShouldNotBeAbleToCallDriverMethodAfterCallingQuit()
123117

124118
[Test]
125119
[NeedsFreshDriver(IsCreatedAfterTest = true)]
126-
[IgnoreBrowser(Browser.Safari)]
127120
public void ShouldBeAbleToDisposeOfDriver()
128121
{
129122
EnvironmentManager.Instance.CloseCurrentDriver();
@@ -134,7 +127,6 @@ public void ShouldBeAbleToDisposeOfDriver()
134127

135128
[Test]
136129
[NeedsFreshDriver(IsCreatedAfterTest = true)]
137-
[IgnoreBrowser(Browser.Safari)]
138130
public void ShouldBeAbleToCallDisposeConsecutively()
139131
{
140132
EnvironmentManager.Instance.CloseCurrentDriver();
@@ -146,7 +138,6 @@ public void ShouldBeAbleToCallDisposeConsecutively()
146138

147139
[Test]
148140
[NeedsFreshDriver(IsCreatedAfterTest = true)]
149-
[IgnoreBrowser(Browser.Safari)]
150141
public void ShouldBeAbleToCallQuitConsecutively()
151142
{
152143
driver.Url = simpleTestPage;

‎dotnet/test/common/ExecutingAsyncJavascriptTest.cs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
namespace OpenQA.Selenium
66
{
77
[TestFixture]
8-
[IgnoreBrowser(Browser.Safari)]
8+
//[IgnoreBrowser(Browser.Safari)]
99
public class ExecutingAsyncJavascriptTest : DriverTestFixture
1010
{
1111
private IJavaScriptExecutor executor;
@@ -236,7 +236,8 @@ public void ShouldBeAbleToMakeXMLHttpRequestsAndWaitForTheResponse()
236236
[IgnoreBrowser(Browser.IE, "Does not handle async alerts")]
237237
[IgnoreBrowser(Browser.IPhone, "Does not handle async alerts")]
238238
[IgnoreBrowser(Browser.Opera, "Does not handle async alerts")]
239-
[IgnoreBrowser(Browser.Firefox, "Unexpected alert from JavaScript not handled properly. Spec difference.")]
239+
[IgnoreBrowser(Browser.Safari, "Does not handle async alerts")]
240+
[IgnoreBrowser(Browser.Firefox, "Unexpected alert from JavaScript not handled properly. Spec difference.")]
240241
public void ThrowsIfScriptTriggersAlert()
241242
{
242243
driver.Url = simpleTestPage;
@@ -318,7 +319,8 @@ public void ThrowsIfScriptTriggersAlertWhichTimesOut()
318319
[IgnoreBrowser(Browser.IE, "Does not handle async alerts")]
319320
[IgnoreBrowser(Browser.IPhone, "Does not handle async alerts")]
320321
[IgnoreBrowser(Browser.Opera, "Does not handle async alerts")]
321-
[IgnoreBrowser(Browser.Firefox, "Unexpected alert from JavaScript not handled properly. Spec difference.")]
322+
[IgnoreBrowser(Browser.Safari, "Does not handle async alerts")]
323+
[IgnoreBrowser(Browser.Firefox, "Unexpected alert from JavaScript not handled properly. Spec difference.")]
322324
public void ThrowsIfAlertHappensDuringScriptWhichTimesOut()
323325
{
324326
driver.Url = slowLoadingAlertPage;
@@ -345,7 +347,8 @@ public void ThrowsIfAlertHappensDuringScriptWhichTimesOut()
345347
[IgnoreBrowser(Browser.IPhone, "Does not handle async alerts")]
346348
[IgnoreBrowser(Browser.Opera, "Does not handle async alerts")]
347349
[IgnoreBrowser(Browser.Safari, "Does not handle async alerts")]
348-
[IgnoreBrowser(Browser.Firefox, "Unexpected alert from JavaScript not handled properly. Spec difference.")]
350+
[IgnoreBrowser(Browser.Safari, "Does not handle async alerts")]
351+
[IgnoreBrowser(Browser.Firefox, "Unexpected alert from JavaScript not handled properly. Spec difference.")]
349352
public void IncludesAlertTextInUnhandledAlertException()
350353
{
351354
driver.Manage().Timeouts().AsynchronousJavaScript = TimeSpan.FromSeconds(5);

‎dotnet/test/common/ExecutingJavascriptTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -511,6 +511,7 @@ public void ShouldBeAbleToHandleAnArrayOfElementsAsAnObjectArray()
511511
[IgnoreBrowser(Browser.Android, "Android not tested")]
512512
[IgnoreBrowser(Browser.Opera, "Opera obeys the method contract.")]
513513
[IgnoreBrowser(Browser.HtmlUnit, "HtmlUnit obeys the method contract.")]
514+
[IgnoreBrowser(Browser.Firefox)]
514515
public void ShouldBeAbleToPassADictionaryAsAParameter()
515516
{
516517
driver.Url = simpleTestPage;

‎dotnet/test/common/FormHandlingTests.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public void ShouldSubmitAFormWhenAnyElementWithinThatFormIsSubmitted()
6565
[IgnoreBrowser(Browser.IPhone)]
6666
[IgnoreBrowser(Browser.Opera)]
6767
[IgnoreBrowser(Browser.PhantomJS)]
68-
[IgnoreBrowser(Browser.Safari)]
68+
//[IgnoreBrowser(Browser.Safari)]
6969
public void ShouldNotBeAbleToSubmitAFormThatDoesNotExist()
7070
{
7171
driver.Url = formsPage;
@@ -137,7 +137,7 @@ public void ShouldEnterDataIntoFormFields()
137137
[Test]
138138
[IgnoreBrowser(Browser.Android, "Does not yet support file uploads")]
139139
[IgnoreBrowser(Browser.IPhone, "Does not yet support file uploads")]
140-
[IgnoreBrowser(Browser.Safari, "Does not yet support file uploads")]
140+
//[IgnoreBrowser(Browser.Safari, "Does not yet support file uploads")]
141141
[IgnoreBrowser(Browser.WindowsPhone, "Does not yet support file uploads")]
142142
public void ShouldBeAbleToAlterTheContentsOfAFileUploadInputElement()
143143
{
@@ -161,7 +161,7 @@ public void ShouldBeAbleToAlterTheContentsOfAFileUploadInputElement()
161161
[Test]
162162
[IgnoreBrowser(Browser.Android, "Does not yet support file uploads")]
163163
[IgnoreBrowser(Browser.IPhone, "Does not yet support file uploads")]
164-
[IgnoreBrowser(Browser.Safari, "Does not yet support file uploads")]
164+
//[IgnoreBrowser(Browser.Safari, "Does not yet support file uploads")]
165165
[IgnoreBrowser(Browser.WindowsPhone, "Does not yet support file uploads")]
166166
public void ShouldBeAbleToSendKeysToAFileUploadInputElementInAnXhtmlDocument()
167167
{
@@ -192,7 +192,7 @@ public void ShouldBeAbleToSendKeysToAFileUploadInputElementInAnXhtmlDocument()
192192
[Test]
193193
[IgnoreBrowser(Browser.Android, "Does not yet support file uploads")]
194194
[IgnoreBrowser(Browser.IPhone, "Does not yet support file uploads")]
195-
[IgnoreBrowser(Browser.Safari, "Does not yet support file uploads")]
195+
//[IgnoreBrowser(Browser.Safari, "Does not yet support file uploads")]
196196
[IgnoreBrowser(Browser.WindowsPhone, "Does not yet support file uploads")]
197197
public void ShouldBeAbleToUploadTheSameFileTwice()
198198
{
@@ -320,7 +320,7 @@ public void HandleFormWithJavascriptAction()
320320
[Test]
321321
[IgnoreBrowser(Browser.Android, "Untested")]
322322
[IgnoreBrowser(Browser.IPhone, "Untested")]
323-
[IgnoreBrowser(Browser.Safari, "Untested")]
323+
//[IgnoreBrowser(Browser.Safari, "Untested")]
324324
public void CanClickOnASubmitButton()
325325
{
326326
CheckSubmitButton("internal_explicit_submit");
@@ -329,7 +329,7 @@ public void CanClickOnASubmitButton()
329329
[Test]
330330
[IgnoreBrowser(Browser.Android, "Untested")]
331331
[IgnoreBrowser(Browser.IPhone, "Untested")]
332-
[IgnoreBrowser(Browser.Safari, "Untested")]
332+
// [IgnoreBrowser(Browser.Safari, "Untested")]
333333
public void CanClickOnAnImplicitSubmitButton()
334334
{
335335
CheckSubmitButton("internal_implicit_submit");
@@ -338,7 +338,7 @@ public void CanClickOnAnImplicitSubmitButton()
338338
[Test]
339339
[IgnoreBrowser(Browser.Android, "Untested")]
340340
[IgnoreBrowser(Browser.IPhone, "Untested")]
341-
[IgnoreBrowser(Browser.Safari, "Untested")]
341+
//[IgnoreBrowser(Browser.Safari, "Untested")]
342342
[IgnoreBrowser(Browser.HtmlUnit, "Fails on HtmlUnit")]
343343
[IgnoreBrowser(Browser.IE, "Fails on IE")]
344344
public void CanClickOnAnExternalSubmitButton()
@@ -349,7 +349,7 @@ public void CanClickOnAnExternalSubmitButton()
349349
[Test]
350350
[IgnoreBrowser(Browser.Android, "Untested")]
351351
[IgnoreBrowser(Browser.IPhone, "Untested")]
352-
[IgnoreBrowser(Browser.Safari, "Untested")]
352+
// [IgnoreBrowser(Browser.Safari, "Untested")]
353353
[IgnoreBrowser(Browser.HtmlUnit, "Fails on HtmlUnit")]
354354
[IgnoreBrowser(Browser.IE, "Fails on IE")]
355355
public void CanClickOnAnExternalImplicitSubmitButton()

‎dotnet/test/common/FrameSwitchingTest.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,6 @@ public void ShouldThrowAnExceptionWhenAFrameCannotBeFoundByIndex()
217217
[Test]
218218
[IgnoreBrowser(Browser.Chrome, "Browser does not support parent frame navigation")]
219219
[IgnoreBrowser(Browser.PhantomJS, "Browser does not support parent frame navigation")]
220-
[IgnoreBrowser(Browser.Safari, "Browser does not support parent frame navigation")]
221220
[IgnoreBrowser(Browser.Android, "Browser does not support parent frame navigation")]
222221
[IgnoreBrowser(Browser.PhantomJS, "Browser does not support parent frame navigation")]
223222
[IgnoreBrowser(Browser.Opera, "Browser does not support parent frame navigation")]
@@ -231,7 +230,6 @@ public void ShouldBeAbleToSwitchToParentFrame()
231230
[Test]
232231
[IgnoreBrowser(Browser.Chrome, "Browser does not support parent frame navigation")]
233232
[IgnoreBrowser(Browser.PhantomJS, "Browser does not support parent frame navigation")]
234-
[IgnoreBrowser(Browser.Safari, "Browser does not support parent frame navigation")]
235233
[IgnoreBrowser(Browser.Android, "Browser does not support parent frame navigation")]
236234
[IgnoreBrowser(Browser.PhantomJS, "Browser does not support parent frame navigation")]
237235
[IgnoreBrowser(Browser.Opera, "Browser does not support parent frame navigation")]
@@ -246,7 +244,6 @@ public void ShouldBeAbleToSwitchToParentFrameFromASecondLevelFrame()
246244
[Test]
247245
[IgnoreBrowser(Browser.Chrome, "Browser does not support parent frame navigation")]
248246
[IgnoreBrowser(Browser.PhantomJS, "Browser does not support parent frame navigation")]
249-
[IgnoreBrowser(Browser.Safari, "Browser does not support parent frame navigation")]
250247
[IgnoreBrowser(Browser.Android, "Browser does not support parent frame navigation")]
251248
[IgnoreBrowser(Browser.PhantomJS, "Browser does not support parent frame navigation")]
252249
[IgnoreBrowser(Browser.Opera, "Browser does not support parent frame navigation")]
@@ -260,7 +257,6 @@ public void SwitchingToParentFrameFromDefaultContextIsNoOp()
260257
[Test]
261258
[IgnoreBrowser(Browser.Chrome, "Browser does not support parent frame navigation")]
262259
[IgnoreBrowser(Browser.PhantomJS, "Browser does not support parent frame navigation")]
263-
[IgnoreBrowser(Browser.Safari, "Browser does not support parent frame navigation")]
264260
[IgnoreBrowser(Browser.Android, "Browser does not support parent frame navigation")]
265261
[IgnoreBrowser(Browser.PhantomJS, "Browser does not support parent frame navigation")]
266262
[IgnoreBrowser(Browser.Opera, "Browser does not support parent frame navigation")]

0 commit comments

Comments
 (0)