Skip to content

Commit 31a09c6

Browse files
committed
[rb] Wrapping browser name when calling Selenium Manager
Also, showing returned message as a warning
1 parent 82bed10 commit 31a09c6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

rb/lib/selenium/webdriver/common/driver_finder.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def self.path(options, klass)
2828
path ||= begin
2929
SeleniumManager.driver_path(options)
3030
rescue StandardError => e
31-
WebDriver.logger.debug("Unable obtain driver using Selenium Manager\n #{e.message}")
31+
WebDriver.logger.warn("Unable obtain driver using Selenium Manager\n #{e.message}")
3232
nil
3333
end
3434
msg = "Unable to locate the #{klass::EXECUTABLE} executable; for more information on how to install drivers, " \

rb/lib/selenium/webdriver/common/selenium_manager.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def driver_path(options)
4040
raise ArgumentError, "SeleniumManager requires a WebDriver::Options instance, not #{options.inspect}"
4141
end
4242

43-
command = [binary, '--browser', options.browser_name, '--output', 'json']
43+
command = [binary, '--browser', "'#{options.browser_name}'", '--output', 'json']
4444
if options.browser_version
4545
command << '--browser-version'
4646
command << options.browser_version

0 commit comments

Comments
 (0)