Skip to content

Commit 3aaa364

Browse files
committed
rb - fix tests so Travis passes
1 parent 06afc99 commit 3aaa364

File tree

2 files changed

+13
-29
lines changed

2 files changed

+13
-29
lines changed

rb/spec/integration/selenium/webdriver/target_locator_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,9 +211,9 @@ module WebDriver
211211
driver.switch_to.window(driver.window_handles.first) do
212212
wait.until { driver.title == 'XHTML Test Page' }
213213
end
214-
end
215214

216-
expect(driver.title).to eq('XHTML Test Page')
215+
expect(driver.title).to eq('XHTML Test Page')
216+
end
217217
end
218218

219219
it 'should switch to default content' do

rb/spec/unit/selenium/webdriver/safari/bridge_spec.rb

Lines changed: 11 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -23,47 +23,31 @@ module Selenium
2323
module WebDriver
2424
module Safari
2525
describe Bridge do
26-
let(:server) { double(Server, receive: response).as_null_object }
27-
let(:browser) { double(Browser).as_null_object }
28-
29-
let :response do
30-
{
31-
'id' => '1',
32-
'response' => {
33-
'sessionId' => 'opaque', 'value' => @default_capabilities,
34-
'status' => 0
35-
}
36-
}
37-
end
26+
let(:http) { double(Remote::Http::Default, call: resp).as_null_object }
27+
let(:resp) { {'sessionId' => 'foo', 'value' => @default_capabilities} }
28+
let(:service) { double(Service, start: true, uri: 'http://example.com') }
29+
let(:caps) { {} }
3830

3931
before do
4032
@default_capabilities = Remote::Capabilities.safari.as_json
4133

42-
allow(Server).to receive(:new).and_return(server)
43-
allow(Browser).to receive(:new).and_return(browser)
34+
allow(Safari).to receive(:driver_path).and_return('/foo')
35+
allow(Remote::Capabilities).to receive(:safari).and_return(caps)
36+
allow(Service).to receive(:new).and_return(service)
4437
end
4538

4639
it 'takes desired capabilities' do
4740
custom_caps = Remote::Capabilities.new
4841
custom_caps['foo'] = 'bar'
4942

50-
expect(server).to receive(:send) do |payload|
51-
expect(payload[:command][:parameters][:desiredCapabilities]['foo']).to eq('bar')
43+
expect(http).to receive(:call) do |_, _, payload|
44+
expect(payload[:desiredCapabilities]['foo']).to eq 'bar'
45+
resp
5246
end
5347

54-
Bridge.new(desired_capabilities: custom_caps)
48+
Bridge.new(http_client: http, desired_capabilities: custom_caps)
5549
end
5650

57-
it 'lets direct arguments take presedence over capabilities' do
58-
custom_caps = Remote::Capabilities.new
59-
custom_caps['cleanSession'] = false
60-
61-
expect(server).to receive(:send) do |payload|
62-
expect(payload[:command][:parameters][:desiredCapabilities]['safari.options']['cleanSession']).to eq(true)
63-
end
64-
65-
Bridge.new(clean_session: true)
66-
end
6751
end
6852
end # Safari
6953
end # WebDriver

0 commit comments

Comments
 (0)