[JS] Add test for multiple file upload

AutomatedTester · AutomatedTester · commit 3eab322a550f · 2023-08-11T11:29:30.000+01:00
diff --git a/javascript/node/selenium-webdriver/lib/test/fileserver.js b/javascript/node/selenium-webdriver/lib/test/fileserver.js
@@ -248,9 +248,24 @@ function handleUpload(request, response) {
       response.writeHead(500)
       response.end(err + '')
     } else {
-      response.writeHead(200)
-      response.write(request.files[0].buffer)
-      response.end('<script>window.top.window.onUploadDone();</script>')
+      if (!request.files) {
+        return response.status(400).send('No files were uploaded')
+      }
+
+      let files = []
+      let keys = Object.keys(request.files)
+
+      keys.forEach((file) => {
+        files.push(request.files[file].originalname)
+      })
+
+      response
+        .status(200)
+        .contentType('html')
+        .send(
+          files.join('\n') +
+          '\n<script>window.top.window.onUploadDone();</script>'
+        )
     }
   })
 }
diff --git a/javascript/node/selenium-webdriver/test/upload_test.js b/javascript/node/selenium-webdriver/test/upload_test.js
@@ -29,6 +29,7 @@ const Pages = test.Pages
 test.suite(function (env) {
   var LOREM_IPSUM_TEXT = 'lorem ipsum dolor sit amet'
   var FILE_HTML = '<!DOCTYPE html><div>' + LOREM_IPSUM_TEXT + '</div>'
+  var FILE_HTML_2 = '<!DOCTYPE html><div>' + "I love sausages too" + '</div>'
 
   var _fp
   before(function () {
@@ -49,6 +50,41 @@ test.suite(function (env) {
     }
   })
 
+  test
+    .ignore(env.browsers(Browser.SAFARI))
+    .it('can upload multiple files', async function () {
+      driver.setFileDetector(new remote.FileDetector())
+
+      await driver.get(Pages.uploadPage)
+
+      var fp1 = await io.tmpFile().then(function (fp) {
+        fs.writeFileSync(fp, FILE_HTML)
+        return fp
+      })
+
+      var fp2 = await io.tmpFile().then(function (fp) {
+        fs.writeFileSync(fp, FILE_HTML_2)
+        return fp
+      })
+
+      await driver.findElement(By.id('upload')).sendKeys(fp1 + '\n' + fp2)
+      await driver.findElement(By.id('go')).click()
+
+      // Uploading files across a network may take a while, even if they're small.
+      var label = await driver.findElement(By.id('upload_label'))
+      await driver.wait(
+        until.elementIsNotVisible(label),
+        10 * 1000,
+        'File took longer than 10 seconds to upload!'
+      )
+
+      var frame = await driver.findElement(By.id('upload_target'))
+      await driver.switchTo().frame(frame)
+      const txt = await driver.findElement(By.css('body')).getText()
+      assert.match(txt, new RegExp(fp1.split('/').pop()))
+      assert.match(txt, new RegExp(fp2.split('/').pop()))
+    })
+
   test
     .ignore(env.browsers(Browser.SAFARI))
     .it('can upload files', async function () {
@@ -63,7 +99,6 @@ test.suite(function (env) {
 
       await driver.findElement(By.id('upload')).sendKeys(fp)
       await driver.findElement(By.id('go')).click()
-
       // Uploading files across a network may take a while, even if they're small.
       var label = await driver.findElement(By.id('upload_label'))
       await driver.wait(
@@ -74,9 +109,11 @@ test.suite(function (env) {
 
       var frame = await driver.findElement(By.id('upload_target'))
       await driver.switchTo().frame(frame)
+      const txt = await driver.findElement(By.css('body')).getText();
       assert.strictEqual(
-        await driver.findElement(By.css('body')).getText(),
-        LOREM_IPSUM_TEXT
+        txt,
+        fp.split('/').pop(),
+        `The document contained ${await driver.getPageSource()}`
       )
     })
 })
