Skip to content

Commit 3f41a29

Browse files
committed
Allow buck to be downloaded and called with multiple targets.
It turns out that the way that we constructed the lambda containing the buck invocation meant that we'd always be including the first target passed to it, no matter how many other invocations there were. *sigh* One day we'll all know how to write nice Ruby. :)
1 parent 22cec65 commit 3f41a29

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

rake-tasks/buck.rb

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,13 @@ def self.download
4444
end
4545

4646
def self.buck_cmd
47-
@@buck_cmd ||= (
47+
(
4848
lambda { |command, args, &block|
49-
args ||= []
50-
buck = Buck::download
49+
buck = []
50+
pex = Buck::download
51+
buck.push(*pex)
5152

53+
args ||= []
5254
buck.push(command)
5355
buck.push(*args)
5456

@@ -89,7 +91,6 @@ def output
8991
}
9092
)
9193

92-
#block.call(output) if block
9394
end
9495

9596
def self.enhance_task(task)

0 commit comments

Comments
 (0)