Skip to content

Commit 43ab383

Browse files
harsha509harsha509
committed
[js] replacing asserts equal with strictEqual and deepEqual with deepStrictEqual
1 parent a08fa1e commit 43ab383

File tree

15 files changed

+271
-272
lines changed

15 files changed

+271
-272
lines changed

‎javascript/node/selenium-webdriver/test/chrome/devtools_test.js

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ const fileServer = require('../../lib/test/fileserver')
2727
const io = require('../../io')
2828
const test = require('../../lib/test')
2929
const until = require('../../lib/until')
30-
const Server = require('../../lib/test/httpserver').Server
3130

3231
test.suite(
3332
function (env) {
@@ -43,31 +42,31 @@ test.suite(
4342

4443
it('can send commands to devtools', async function () {
4544
await driver.get(test.Pages.ajaxyPage)
46-
assert.equal(await driver.getCurrentUrl(), test.Pages.ajaxyPage)
45+
assert.strictEqual(await driver.getCurrentUrl(), test.Pages.ajaxyPage)
4746

4847
await driver.sendDevToolsCommand('Page.navigate', {
4948
url: test.Pages.echoPage,
5049
})
51-
assert.equal(await driver.getCurrentUrl(), test.Pages.echoPage)
50+
assert.strictEqual(await driver.getCurrentUrl(), test.Pages.echoPage)
5251
})
5352

5453
it('can send commands to devtools and get return', async function () {
5554
await driver.get(test.Pages.ajaxyPage)
56-
assert.equal(await driver.getCurrentUrl(), test.Pages.ajaxyPage)
55+
assert.strictEqual(await driver.getCurrentUrl(), test.Pages.ajaxyPage)
5756

5857
await driver.get(test.Pages.echoPage)
59-
assert.equal(await driver.getCurrentUrl(), test.Pages.echoPage)
58+
assert.strictEqual(await driver.getCurrentUrl(), test.Pages.echoPage)
6059

6160
let history = await driver.sendAndGetDevToolsCommand(
6261
'Page.getNavigationHistory'
6362
)
6463
assert(history)
6564
assert(history.currentIndex >= 2)
66-
assert.equal(
65+
assert.strictEqual(
6766
history.entries[history.currentIndex].url,
6867
test.Pages.echoPage
6968
)
70-
assert.equal(
69+
assert.strictEqual(
7170
history.entries[history.currentIndex - 1].url,
7271
test.Pages.ajaxyPage
7372
)
@@ -100,15 +99,15 @@ test.suite(
10099
it('calls the event listener for console.log', async function () {
101100
const cdpConnection = await driver.createCDPConnection('page')
102101
await driver.onLogEvent(cdpConnection, function (event) {
103-
assert.equal(event['args'][0]['value'], 'here')
102+
assert.strictEqual(event['args'][0]['value'], 'here')
104103
})
105104
await driver.executeScript('console.log("here")')
106105
})
107106

108107
it('calls the event listener for js exceptions', async function () {
109108
const cdpConnection = await driver.createCDPConnection('page')
110109
await driver.onLogException(cdpConnection, function (event) {
111-
assert.equal(
110+
assert.strictEqual(
112111
event['exceptionDetails']['stackTrace']['callFrames'][0][
113112
'functionName'
114113
],
@@ -125,9 +124,9 @@ test.suite(
125124
it('calls the event listener on dom mutations', async function () {
126125
const cdpConnection = await driver.createCDPConnection('page')
127126
await driver.logMutationEvents(cdpConnection, function (event) {
128-
assert.equal(event['attribute_name'], 'style')
129-
assert.equal(event['current_value'], '')
130-
assert.equal(event['old_value'], 'display:none;')
127+
assert.strictEqual(event['attribute_name'], 'style')
128+
assert.strictEqual(event['current_value'], '')
129+
assert.strictEqual(event['old_value'], 'display:none;')
131130
})
132131

133132
await driver.get(fileServer.Pages.dynamicPage)
@@ -156,7 +155,7 @@ test.suite(
156155
await driver.register('genie', 'bottle', pageCdpConnection)
157156
await driver.get(fileServer.Pages.basicAuth)
158157
let source = await driver.getPageSource()
159-
assert.equal(source.includes('Access granted!'), true)
158+
assert.strictEqual(source.includes('Access granted!'), true)
160159
})
161160
})
162161

@@ -178,7 +177,7 @@ test.suite(
178177
__dirname,
179178
'../../lib/test/data/firefox/webextension.xpi'
180179
)
181-
assert.equal(
180+
assert.strictEqual(
182181
fs.readFileSync(downloadPath, 'binary'),
183182
fs.readFileSync(goldenPath, 'binary')
184183
)

‎javascript/node/selenium-webdriver/test/chrome/options_test.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@ describe('chrome.Options', function () {
2828
describe('addArguments', function () {
2929
it('takes var_args', function () {
3030
let options = new chrome.Options()
31-
assert.deepEqual(options[symbols.serialize](), {
31+
assert.deepStrictEqual(options[symbols.serialize](), {
3232
browserName: 'chrome',
3333
'goog:chromeOptions': {},
3434
})
3535

3636
options.addArguments('a', 'b')
37-
assert.deepEqual(options[symbols.serialize](), {
37+
assert.deepStrictEqual(options[symbols.serialize](), {
3838
browserName: 'chrome',
3939
'goog:chromeOptions': {
4040
args: ['a', 'b'],
@@ -44,13 +44,13 @@ describe('chrome.Options', function () {
4444

4545
it('flattens input arrays', function () {
4646
let options = new chrome.Options()
47-
assert.deepEqual(options[symbols.serialize](), {
47+
assert.deepStrictEqual(options[symbols.serialize](), {
4848
browserName: 'chrome',
4949
'goog:chromeOptions': {},
5050
})
5151

5252
options.addArguments(['a', 'b'], 'c', [1, 2], 3)
53-
assert.deepEqual(options[symbols.serialize](), {
53+
assert.deepStrictEqual(options[symbols.serialize](), {
5454
browserName: 'chrome',
5555
'goog:chromeOptions': {
5656
args: ['a', 'b', 'c', 1, 2, 3],
@@ -65,15 +65,15 @@ describe('chrome.Options', function () {
6565
assert.strictEqual(options.options_.extensions, undefined)
6666

6767
options.addExtensions('a', 'b')
68-
assert.deepEqual(options.options_.extensions, ['a', 'b'])
68+
assert.deepStrictEqual(options.options_.extensions, ['a', 'b'])
6969
})
7070

7171
it('flattens input arrays', function () {
7272
let options = new chrome.Options()
7373
assert.strictEqual(options.options_.extensions, undefined)
7474

7575
options.addExtensions(['a', 'b'], 'c', [1, 2], 3)
76-
assert.deepEqual(options.options_.extensions, ['a', 'b', 'c', 1, 2, 3])
76+
assert.deepStrictEqual(options.options_.extensions, ['a', 'b', 'c', 1, 2, 3])
7777
})
7878
})
7979

@@ -84,8 +84,8 @@ describe('chrome.Options', function () {
8484
.addExtensions(__filename)
8585
[symbols.serialize]()
8686

87-
assert.equal(wire['goog:chromeOptions'].extensions.length, 1)
88-
assert.equal(await wire['goog:chromeOptions'].extensions[0], expected)
87+
assert.strictEqual(wire['goog:chromeOptions'].extensions.length, 1)
88+
assert.strictEqual(await wire['goog:chromeOptions'].extensions[0], expected)
8989
})
9090
})
9191
})
@@ -109,7 +109,7 @@ test.suite(
109109
var userAgent = await driver.executeScript(
110110
'return window.navigator.userAgent'
111111
)
112-
assert.equal(userAgent, 'foo;bar')
112+
assert.strictEqual(userAgent, 'foo;bar')
113113
})
114114
})
115115
},

‎javascript/node/selenium-webdriver/test/http/http_test.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -113,21 +113,21 @@ describe('HttpClient', function () {
113113

114114
const client = new HttpClient(server.url(), agent)
115115
return client.send(request).then(function (response) {
116-
assert.equal(200, response.status)
116+
assert.strictEqual(200, response.status)
117117

118118
const headers = JSON.parse(response.body)
119-
assert.equal(headers['content-length'], '0')
120-
assert.equal(headers['connection'], 'keep-alive')
121-
assert.equal(headers['host'], server.host())
119+
assert.strictEqual(headers['content-length'], '0')
120+
assert.strictEqual(headers['connection'], 'keep-alive')
121+
assert.strictEqual(headers['host'], server.host())
122122

123123
const regex = /^selenium\/.* \(js (windows|mac|linux)\)$/
124124
assert.ok(
125125
regex.test(headers['user-agent']),
126126
`${headers['user-agent']} does not match ${regex}`
127127
)
128128

129-
assert.equal(request.headers.get('Foo'), 'Bar')
130-
assert.equal(
129+
assert.strictEqual(request.headers.get('Foo'), 'Bar')
130+
assert.strictEqual(
131131
request.headers.get('Accept'),
132132
'application/json; charset=utf-8'
133133
)

‎javascript/node/selenium-webdriver/test/http/util_test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ describe('selenium-webdriver/http/util', function () {
6767
describe('#getStatus', function () {
6868
it('should return value field on success', function () {
6969
return util.getStatus(baseUrl).then(function (response) {
70-
assert.equal('abc123', response)
70+
assert.strictEqual('abc123', response)
7171
})
7272
})
7373

@@ -79,8 +79,8 @@ describe('selenium-webdriver/http/util', function () {
7979
},
8080
function (err) {
8181
assert.ok(err instanceof error.WebDriverError)
82-
assert.equal(err.code, error.WebDriverError.code)
83-
assert.equal(err.message, value)
82+
assert.strictEqual(err.code, error.WebDriverError.code)
83+
assert.strictEqual(err.message, value)
8484
}
8585
)
8686
})

‎javascript/node/selenium-webdriver/test/ie/options_test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ test.suite(
7575
caps = caps.map_.get(ie.VENDOR_COMMAND_PREFIX)[
7676
ie.Key.ELEMENT_SCROLL_BEHAVIOR
7777
]
78-
assert.equal(caps, ie.Behavior.TOP)
78+
assert.strictEqual(caps, ie.Behavior.TOP)
7979
await driver.quit()
8080
})
8181

@@ -90,16 +90,16 @@ test.suite(
9090
caps = caps.map_.get(ie.VENDOR_COMMAND_PREFIX)[
9191
ie.Key.BROWSER_COMMAND_LINE_SWITCHES
9292
]
93-
assert.equal(caps, '-k -private')
93+
assert.strictEqual(caps, '-k -private')
9494
await driver.quit()
9595
})
9696

9797
it('can set capability', async function () {
9898
let caps = Capabilities.ie()
9999
assert.ok(!caps.has('silent'))
100-
assert.equal(undefined, caps.get('silent'))
100+
assert.strictEqual(undefined, caps.get('silent'))
101101
caps.set('silent', true)
102-
assert.equal(true, caps.get('silent'))
102+
assert.strictEqual(true, caps.get('silent'))
103103
assert.ok(caps.has('silent'))
104104
})
105105
})

‎javascript/node/selenium-webdriver/test/io/zip_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ describe('io/zip', function () {
9494
return z.getFile('foo')
9595
})
9696
.then((buffer) =>
97-
assert.equal(buffer.toString('utf8'), 'hello, world!')
97+
assert.strictEqual(buffer.toString('utf8'), 'hello, world!')
9898
)
9999
})
100100

0 commit comments

Comments
 (0)