Adding __repr__ for wait object in [python] bindings

Moving tests to their own class

more work to fix #588

Author: santiycr

py/selenium/webdriver/support/wait.py

@@ -55,6 +55,10 @@ def __init__(self, driver, timeout, poll_frequency=POLL_FREQUENCY, ignored_excep
                 exceptions.append(ignored_exceptions)
         self._ignored_exceptions = tuple(exceptions)
 
+    def __repr__(self):
+        return '<{0.__module__}.{0.__name__} (session="{1}")>'.format(
+            type(self), self._driver.session_id)
+
     def until(self, method, message=''):
         """Calls the method provided with the driver as an argument until the \
         return value is not False."""

py/test/selenium/webdriver/common/element_attribute_tests.py

@@ -22,14 +22,6 @@
 
 class ElementAttributeTests(unittest.TestCase):
 
-    def testShouldImplementReprForWebElement(self):
-        self._loadSimplePage()
-        elem = self.driver.find_element_by_id("validImgTag")
-        elem_repr = repr(elem)
-        self.assertTrue( "WebElement" in elem_repr)
-        self.assertTrue( "session=" in elem_repr)
-        self.assertTrue( "element=" in elem_repr)
-
     def testShouldReturnNullWhenGettingTheValueOfAnAttributeThatIsNotListed(self):
         self._loadSimplePage()
         head = self.driver.find_element_by_xpath("/html")

py/test/selenium/webdriver/common/repr_tests.py

@@ -0,0 +1,41 @@
+# Licensed to the Software Freedom Conservancy (SFC) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The SFC licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import unittest
+from selenium.webdriver.support.wait import WebDriverWait
+
+
+class ClassReprTests(unittest.TestCase):
+
+    def testShouldImplementReprForWebDriver(self):
+        driver_repr = repr(self.driver)
+        self.assertTrue(type(self.driver).__name__ in driver_repr)
+        self.assertTrue(self.driver.session_id in driver_repr)
+
+    def testShouldImplementReprForWebElement(self):
+        self.driver.get(self.webserver.where_is('simpleTest.html'))
+        elem = self.driver.find_element_by_id("validImgTag")
+        elem_repr = repr(elem)
+        self.assertTrue(type(elem).__name__ in elem_repr)
+        self.assertTrue(self.driver.session_id in elem_repr)
+        self.assertTrue(elem._id in elem_repr)
+
+    def testShouldImplementReprForWait(self):
+        wait = WebDriverWait(self.driver, 30)
+        wait_repr = repr(wait)
+        self.assertTrue(type(wait).__name__ in wait_repr)
+        self.assertTrue(self.driver.session_id in wait_repr)