Skip to content

Commit 516fd67

Browse files
committed
Firefox: fixing the most critical v.44 compatibility issue (inability to open a page)
1 parent d2b5fee commit 516fd67

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

javascript/firefox-driver/js/moz.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ fxdriver.moz.unwrap = function(thing) {
139139
fxdriver.moz.markUnwrapped_ = function(thing) {
140140
Object.defineProperty(thing, '__fxdriver_unwrapped', {
141141
enumerable: false,
142-
configurable: false,
142+
configurable: true,
143143
writable: true,
144144
value: true
145145
});

javascript/firefox-driver/js/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ Utils.initWebLoadingListener = function(respond, opt_window) {
153153
// Wait for the reload to finish before sending the response.
154154
new WebLoadingListener(browser, function(timedOut, opt_stopWaiting) {
155155
// Reset to the top window.
156-
respond.session.setWindow(topWindow);
156+
respond.session.setWindow(browser.contentWindow);
157157
if (opt_stopWaiting) {
158158
respond.session.setWaitForPageLoad(false);
159159
}

javascript/firefox-driver/js/webLoadingListener.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ WebLoadingListener = function(browser, toCall, timeout, opt_window) {
253253
* @param {!WebLoadingListener} listener The listener to remove.
254254
*/
255255
WebLoadingListener.removeListener = function(browser, listener) {
256-
if (browser.removeProgressListener) {
256+
if (browser.removeProgressListener && listener.handler) {
257257
browser.removeProgressListener(listener.handler);
258258
}
259259
};

0 commit comments

Comments
 (0)