Fixing HSL to RGB converter in Java

Author: barancev

java/client/src/org/openqa/selenium/support/Color.java

@@ -260,9 +260,9 @@ protected Color createColor(Matcher matcher, double a) {
         b = hueToRgb(luminocity1, luminocity2, h - 1.0 / 3.0);
       }
 
-      return new Color((short) (r * 256),
-          (short) (g * 256),
-          (short) (b * 256),
+      return new Color((short) Math.round(r * 255),
+          (short) Math.round(g * 255),
+          (short) Math.round(b * 255),
           a);
     }
 

java/client/test/org/openqa/selenium/support/ColorTest.java

@@ -106,6 +106,18 @@ public void hslToRgba() {
     hsl = "hsl(100, 0%, 50%)";
     rgba = "rgba(128, 128, 128, 1)";
     assertEquals(rgba, Color.fromString(hsl).asRgba());
+    hsl = "hsl(0, 100%, 50%)"; // red
+    rgba = "rgba(255, 0, 0, 1)";
+    assertEquals(rgba, Color.fromString(hsl).asRgba());
+    hsl = "hsl(120, 100%, 50%)"; // green
+    rgba = "rgba(0, 255, 0, 1)";
+    assertEquals(rgba, Color.fromString(hsl).asRgba());
+    hsl = "hsl(240, 100%, 50%)"; // blue
+    rgba = "rgba(0, 0, 255, 1)";
+    assertEquals(rgba, Color.fromString(hsl).asRgba());
+    hsl = "hsl(0, 0%, 100%)"; // white
+    rgba = "rgba(255, 255, 255, 1)";
+    assertEquals(rgba, Color.fromString(hsl).asRgba());
   }
 
   @Test