Skip to content

Commit 5a715b6

Browse files
committed
Default firefox in tests to use marionette
It's about time to do this.
1 parent c314b3a commit 5a715b6

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

java/client/test/org/openqa/selenium/testing/drivers/BrowserToCapabilities.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,10 @@ public static DesiredCapabilities of(Browser browser) {
3737

3838
case ff:
3939
caps = DesiredCapabilities.firefox();
40-
caps.setCapability(FirefoxDriver.MARIONETTE,
41-
Boolean.getBoolean(FirefoxDriver.SystemProperty.DRIVER_USE_MARIONETTE));
40+
String property =
41+
System.getProperty(FirefoxDriver.SystemProperty.DRIVER_USE_MARIONETTE, "true");
42+
boolean useMarionette = property != null && Boolean.parseBoolean(property);
43+
caps.setCapability(FirefoxDriver.MARIONETTE, useMarionette);
4244
break;
4345

4446
case htmlunit:

java/client/test/org/openqa/selenium/testing/drivers/SynthesizedFirefoxDriver.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,6 @@ private static Capabilities tweakCapabilities(Capabilities desiredCaps) {
6767
}
6868
DesiredCapabilities tweaked = new DesiredCapabilities(desiredCaps);
6969

70-
if (!Boolean.TRUE.equals(tweaked.getCapability(MARIONETTE))) {
71-
tweaked.setCapability(MARIONETTE, false);
72-
}
73-
7470
if (tweaked.getCapability(PROFILE) == null) {
7571
tweaked.setCapability(PROFILE, createTemporaryProfile());
7672
} else {

0 commit comments

Comments
 (0)