Firefox: fixing events generated as a result of click on an element that disappears after the click.

Author: barancev

java/client/test/org/openqa/selenium/CorrectEventFiringTest.java

@@ -31,23 +31,23 @@
 import static org.openqa.selenium.WaitingConditions.elementTextToEqual;
 import static org.openqa.selenium.WaitingConditions.elementValueToEqual;
 import static org.openqa.selenium.support.ui.ExpectedConditions.visibilityOfElementLocated;
-import static org.openqa.selenium.testing.Ignore.Driver.FIREFOX;
+import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
 import static org.openqa.selenium.testing.Ignore.Driver.HTMLUNIT;
 import static org.openqa.selenium.testing.Ignore.Driver.IE;
 import static org.openqa.selenium.testing.Ignore.Driver.MARIONETTE;
 import static org.openqa.selenium.testing.Ignore.Driver.SAFARI;
 
-import java.io.File;
-import java.io.IOException;
-import java.util.List;
-
 import org.junit.Test;
 import org.openqa.selenium.testing.Ignore;
 import org.openqa.selenium.testing.JUnit4TestBase;
 import org.openqa.selenium.testing.JavascriptEnabled;
 import org.openqa.selenium.testing.TestUtilities;
 import org.openqa.selenium.testing.drivers.SauceDriver;
 
+import java.io.File;
+import java.io.IOException;
+import java.util.List;
+
 public class CorrectEventFiringTest extends JUnit4TestBase {
 
   @JavascriptEnabled
@@ -414,7 +414,7 @@ public void testClickEventsShouldBubble() {
   }
 
   @JavascriptEnabled
-  @Ignore(value = {MARIONETTE, SAFARI, HTMLUNIT})
+  @Ignore(value = {CHROME, MARIONETTE, SAFARI, HTMLUNIT})
   @Test
   public void testClickOverlappingElements() {
     driver.get(appServer.whereIs("click_tests/overlapping_elements.html"));
@@ -430,7 +430,7 @@ public void testClickOverlappingElements() {
   }
 
   @JavascriptEnabled
-  @Ignore(value = {FIREFOX, MARIONETTE, SAFARI, HTMLUNIT})
+  @Ignore(value = {MARIONETTE, SAFARI, HTMLUNIT})
   @Test
   public void testClickAnElementThatDisappear() {
     driver.get(appServer.whereIs("click_tests/disappearing_element.html"));

javascript/atoms/action.js

@@ -253,14 +253,16 @@ bot.action.moveMouse = function(element, opt_coords, opt_mouse) {
  * @param {goog.math.Coordinate=} opt_coords Mouse position relative to the
  *   element.
  * @param {bot.Mouse=} opt_mouse Mouse to use; if not provided, constructs one.
+ * @param {boolean=} opt_force Whether the release event should be fired even if the
+ *     element is not interactable.
  * @throws {bot.Error} If the element cannot be interacted with.
  */
-bot.action.click = function(element, opt_coords, opt_mouse) {
+bot.action.click = function(element, opt_coords, opt_mouse, opt_force) {
   var coords = bot.action.prepareToInteractWith_(element, opt_coords);
   var mouse = opt_mouse || new bot.Mouse();
   mouse.move(element, coords);
   mouse.pressButton(bot.Mouse.Button.LEFT);
-  mouse.releaseButton();
+  mouse.releaseButton(opt_force);
 };
 
 

javascript/atoms/mouse.js

@@ -277,8 +277,10 @@ bot.Mouse.prototype.pressButton = function(button) {
 /**
  * Releases the pressed mouse button. Throws exception if no button pressed.
  *
+ * @param {boolean=} opt_force Whether the event should be fired even if the
+ *     element is not interactable.
  */
-bot.Mouse.prototype.releaseButton = function() {
+bot.Mouse.prototype.releaseButton = function(opt_force) {
   if (goog.isNull(this.buttonPressed_)) {
     throw new bot.Error(bot.ErrorCode.UNKNOWN_ERROR,
         'Cannot release a button when no button is pressed.');
@@ -291,7 +293,7 @@ bot.Mouse.prototype.releaseButton = function() {
   // element becomes non-interactable after the mouseup.
   var elementInteractableBeforeMouseup =
       bot.dom.isInteractable(this.getElement());
-  this.fireMouseEvent_(bot.events.EventType.MOUSEUP);
+  this.fireMouseEvent_(bot.events.EventType.MOUSEUP, null, null, opt_force);
 
   // TODO: Middle button can also trigger click.
   if (this.buttonPressed_ == bot.Mouse.Button.LEFT &&

javascript/firefox-driver/js/syntheticMouse.js

@@ -199,7 +199,7 @@ SyntheticMouse.prototype.click = function(target) {
 
   } else {
     goog.log.info(SyntheticMouse.LOG_, 'About to do a bot.action.click on ' + element);
-    bot.action.click(element, this.lastMousePosition, this.getMouse_());
+    bot.action.click(element, this.lastMousePosition, this.getMouse_(), true);
   }
 
   if (bot.dom.isEditable(element) && element.value !== undefined) {