Skip to content

Commit 5f5ea86

Browse files
committed
[grid] Fixing broken managed downloads test
1 parent 1de6a52 commit 5f5ea86

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

java/test/org/openqa/selenium/grid/node/config/NodeOptionsTest.java

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -93,44 +93,48 @@ void canConfigureNodeWithDriverDetection() {
9393
}
9494

9595
@Test
96-
void ensureAutoDownloadsFlagIsAutoInjectedIntoChromeStereoCapabilitiesWhenEnabledForNode() {
96+
void ensureManagedDownloadsFlagIsAutoInjectedIntoChromeStereoCapabilitiesWhenEnabledForNode() {
9797
boolean isEnabled = isDownloadEnabled(new ChromeDriverInfo(), "ChromeDriverInfo");
9898
assertThat(isEnabled).isTrue();
9999
}
100100

101101
@Test
102-
void ensureAutoDownloadsFlagIsAutoInjectedIntoFirefoxStereoCapabilitiesWhenEnabledForNode() {
102+
void ensureManagedDownloadsFlagIsAutoInjectedIntoFirefoxStereoCapabilitiesWhenEnabledForNode() {
103103
boolean isEnabled = isDownloadEnabled(new GeckoDriverInfo(), "GeckoDriverInfo");
104104
assertThat(isEnabled).isTrue();
105105
}
106106

107107
@Test
108-
void ensureAutoDownloadsFlagIsAutoInjectedIntoEdgeStereoCapabilitiesWhenEnabledForNode() {
108+
void ensureManagedDownloadsFlagIsAutoInjectedIntoEdgeStereoCapabilitiesWhenEnabledForNode() {
109109
assumeTrue(Platform.getCurrent().is(Platform.WINDOWS));
110110
boolean isEnabled = isDownloadEnabled(new EdgeDriverInfo(), "EdgeDriverInfo");
111111
assertThat(isEnabled).isTrue();
112112
}
113113

114114
@Test
115-
void ensureAutoDownloadsFlagIsNOTAutoInjectedIntoIEStereoCapabilitiesWhenEnabledForNode() {
115+
void ensureManagedDownloadsFlagIsNOTAutoInjectedIntoIEStereoCapabilitiesWhenEnabledForNode() {
116116
assumeTrue(Platform.getCurrent().is(Platform.WINDOWS));
117117
assumeFalse(Boolean.parseBoolean(System.getenv("GITHUB_ACTIONS")),
118-
"We don't have driver servers in PATH when we run unit tests");
119-
boolean isEnabled = isDownloadEnabled(new InternetExplorerDriverInfo(), "InternetExplorerDriverInfo");
118+
"We don't have driver servers in PATH when we run unit tests");
119+
boolean
120+
isEnabled =
121+
isDownloadEnabled(new InternetExplorerDriverInfo(), "InternetExplorerDriverInfo");
120122
assertThat(isEnabled).isFalse();
121123
}
122124

123125
@Test
124-
void ensureAutoDownloadsFlagIsNOTAutoInjectedIntoSafariStereoCapabilitiesWhenEnabledForNode() {
126+
void ensureManagedDownloadsFlagIsNOTAutoInjectedIntoSafariStereoCapabilitiesWhenEnabledForNode() {
125127
boolean isEnabled = isDownloadEnabled(new SafariDriverInfo(), "SafariDriverInfo");
126128
assertThat(isEnabled).isFalse();
127129
}
128130

129131
boolean isDownloadEnabled(WebDriverInfo driver, String customMsg) {
130132
assumeTrue(driver.isAvailable(), customMsg + " needs to be available");
131-
Config config = new MapConfig(singletonMap("node", ImmutableMap.of("detect-drivers", "true",
132-
"selenium-manager", false,
133-
"enable-manage-downloads", true)));
133+
Config config = new MapConfig(
134+
singletonMap("node", ImmutableMap.of("detect-drivers", "true",
135+
"selenium-manager", false,
136+
"enable-managed-downloads",
137+
true)));
134138
List<Capabilities> reported = new ArrayList<>();
135139
new NodeOptions(config).getSessionFactories(caps -> {
136140
reported.add(caps);

0 commit comments

Comments
 (0)