Handle non-integer stack trace line numbers in .NET

jimevans · jimevans · commit 60766a02b998 · 2016-09-15T09:31:08.000-07:00
The .NET bindings assumed that the stack trace elements in the wire protocol would have line numbers that were integers, as specified in the OSS-dialect of the protocol. This is not necessarily the case, and we need to be a little more forgiving. Fixes issue #2774.
diff --git a/dotnet/src/webdriver/Remote/StackTraceElement.cs b/dotnet/src/webdriver/Remote/StackTraceElement.cs
@@ -60,7 +60,11 @@ public StackTraceElement(Dictionary<string, object> elementAttributes)
 
                 if (elementAttributes.ContainsKey("lineNumber"))
                 {
-                    this.lineNumber = Convert.ToInt32(elementAttributes["lineNumber"], CultureInfo.InvariantCulture);
+                    int line = 0;
+                    if (int.TryParse(elementAttributes["lineNumber"].ToString(), out line))
+                    {
+                        this.lineNumber = line;
+                    }
                 }
 
                 if (elementAttributes.ContainsKey("fileName") && elementAttributes["fileName"] != null)

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,11 @@ public StackTraceElement(Dictionary<string, object> elementAttributes)`
`60`	`60`
`61`	`61`	`if (elementAttributes.ContainsKey("lineNumber"))`
`62`	`62`	`{`
`63`		`- this.lineNumber = Convert.ToInt32(elementAttributes["lineNumber"], CultureInfo.InvariantCulture);`
	`63`	`+ int line = 0;`
	`64`	`+ if (int.TryParse(elementAttributes["lineNumber"].ToString(), out line))`
	`65`	`+ {`
	`66`	`+ this.lineNumber = line;`
	`67`	`+ }`
`64`	`68`	`}`
`65`	`69`
`66`	`70`	`if (elementAttributes.ContainsKey("fileName") && elementAttributes["fileName"] != null)`