Add builder api for setting http agent for each request

Signed-off-by: Jason Leyba <[email protected]>

Author: akhillb

javascript/node/selenium-webdriver/CHANGES.md

@@ -1,3 +1,8 @@
+## v2.54.0-dev
+
+* Allow users to set the agent used for HTTP connections through
+   `builder.Builder#usingHttpAgent()`
+
 ## v2.53.2
 
 * Changed `io.exists()` to return a rejected promise if the input path is not

javascript/node/selenium-webdriver/builder.js

@@ -128,6 +128,9 @@ class Builder {
 
     /** @private {boolean} */
     this.ignoreEnv_ = false;
+
+    /** @private {http.Agent} */
+    this.agent_ = null;
   }
 
   /**
@@ -187,6 +190,25 @@ class Builder {
     return this.proxy_;
   }
 
+  /**
+   * Sets the http agent to use for each request.
+   * If this method is not called, the Builder will use http.globalAgent by default.
+   *
+   * @param {http.Agent} agent The agent to use for each request.
+   * @return {!Builder} A self reference.
+   */
+  usingHttpAgent(agent) {
+    this.agent_ = agent;
+    return this;
+  }
+  
+  /**
+   * @return {http.Agent} The http agent used for each request
+   */
+  getHttpAgent() {
+    return this.agent_;
+  }
+
   /**
    * Sets the desired capabilities when requesting a new session. This will
    * overwrite any previously set capabilities.
@@ -454,7 +476,7 @@ class Builder {
     }
 
     if (url) {
-      var executor = executors.createExecutor(url, this.proxy_);
+      var executor = executors.createExecutor(url, this.agent_, this.proxy_);
       return WebDriver.createSession(executor, capabilities, this.flow_);
     }
 

javascript/node/selenium-webdriver/executors.js

@@ -38,13 +38,15 @@ exports.DeferredExecutor = DeferredExecutor;
  * Creates a command executor that uses WebDriver's JSON wire protocol.
  * @param {(string|!promise.Promise<string>)} url The server's URL,
  *     or a promise that will resolve to that URL.
- * @param {?string=} opt_proxy (optional) The URL of the HTTP proxy for the
- *     client to use.
+ * @param {http.Agent=} opt_agent (optional) The Http.Agent for the client to 
+ *     use. 
+ * @param {(string|null)=} opt_proxy (optional) The URL of the HTTP proxy for
+ *     the client to use.
  * @returns {!./lib/command.Executor} The new command executor.
  */
-exports.createExecutor = function(url, opt_proxy) {
+exports.createExecutor = function(url, opt_agent, opt_proxy) {
   return new DeferredExecutor(promise.when(url, function(url) {
-    var client = new HttpClient(url, null, opt_proxy);
+    var client = new HttpClient(url, opt_agent, opt_proxy);
     return new HttpExecutor(client);
   }));
 };

javascript/node/selenium-webdriver/package.json

@@ -1,6 +1,6 @@
 {
   "name": "selenium-webdriver",
-  "version": "2.53.2",
+  "version": "2.54.0-dev",
   "description": "The official WebDriver JavaScript bindings from the Selenium project",
   "license": "Apache-2.0",
   "keywords": [