Skip to content

Commit 627c0de

Browse files
committed
[rb] fix complexity in options for rubocop
1 parent 1b60931 commit 627c0de

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

rb/.rubocop.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ Metrics/ClassLength:
6464
Metrics/CyclomaticComplexity:
6565
Max: 9
6666
Exclude:
67-
- 'lib/selenium/webdriver/remote/capabilities.rb'
6867
- 'lib/selenium/webdriver/support/color.rb'
6968

7069
Metrics/MethodLength:
@@ -84,11 +83,8 @@ Metrics/ModuleLength:
8483
Metrics/ParameterLists:
8584
CountKeywordArgs: false
8685

87-
# TODO: Refactor Chrome::Bridge#create_capabilities
8886
Metrics/PerceivedComplexity:
89-
Max: 10
90-
Exclude:
91-
- 'lib/selenium/webdriver/remote/capabilities.rb'
87+
Max: 9
9288

9389
Naming/FileName:
9490
Exclude:

rb/lib/selenium/webdriver/common/options.rb

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -134,13 +134,7 @@ def camelize?(_key)
134134

135135
def generate_as_json(value, camelize_keys: true)
136136
if value.is_a?(Hash)
137-
value.each_with_object({}) do |(key, val), hash|
138-
next if val.respond_to?(:empty?) && val.empty?
139-
140-
camelize = camelize_keys ? camelize?(key) : false
141-
key = convert_json_key(key, camelize: camelize)
142-
hash[key] = generate_as_json(val, camelize_keys: camelize)
143-
end
137+
process_json_hash(value, camelize_keys)
144138
elsif value.respond_to?(:as_json)
145139
value.as_json
146140
elsif value.is_a?(Array)
@@ -152,6 +146,16 @@ def generate_as_json(value, camelize_keys: true)
152146
end
153147
end
154148

149+
def process_json_hash(value, camelize_keys)
150+
value.each_with_object({}) do |(key, val), hash|
151+
next if val.respond_to?(:empty?) && val.empty?
152+
153+
camelize = camelize_keys ? camelize?(key) : false
154+
key = convert_json_key(key, camelize: camelize)
155+
hash[key] = generate_as_json(val, camelize_keys: camelize)
156+
end
157+
end
158+
155159
def convert_json_key(key, camelize: true)
156160
key = key.to_s if key.is_a?(Symbol)
157161
key = camel_case(key) if camelize

0 commit comments

Comments
 (0)