Skip to content

Commit 69f44a3

Browse files
committed
[rust] Fix test failures on Windows CI
Apparently the default shell environment on the Windows GitHub Actions runner is missing the PROGRAMFILES and PROGRAMFILES(X86) environment variables.
1 parent e47de45 commit 69f44a3

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

.bazelrc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ build --test_env=DASHBOARD_URL
5252
build --test_env=DISPLAY
5353
build --test_env=FIREFOX_NIGHTLY_BINARY
5454
build --test_env=GITHUB_ACTIONS
55-
build --test_env=LOCALAPPDATA
5655
build --test_env=MOZ_HEADLESS
5756
build --test_env=PATH # Remove once browser pinning works
5857
build --test_env=SELENIUM_BROWSER
@@ -69,10 +68,11 @@ build --test_env=RUBYOPT="-Irb/lib -w"
6968
build --action_env=HOME
7069
test --test_env=HOME
7170

72-
# Expose necessary variables for Seleinum-Manager.
71+
# Expose necessary variables for Selenium-Manager.
7372

74-
test:windows --test_env=PROGRAMFILES
75-
test:windows --test_env="PROGRAMFILES(X86)"="C:\\Program Files (x86)"
73+
test:windows --test_env=LOCALAPPDATA
74+
test:windows --test_env=PROGRAMFILES="C:\\Program Files"
75+
test:windows --test_env=PROGRAMFILES(X86)="C:\\Program Files (x86)"
7676

7777
test --test_timeout=1800
7878

rust/BUILD.bazel

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ rust_test(
2929
size = "small",
3030
srcs = glob(["src/**/*.rs"]),
3131
crate = ":selenium_manager",
32-
tags = ["no-sandbox"],
3332
)
3433

3534
[
@@ -39,11 +38,6 @@ rust_test(
3938
srcs = [file],
4039
data = [":selenium-manager"],
4140
edition = "2021",
42-
tags = [
43-
"exclusive-if-local",
44-
"no-sandbox",
45-
"requires-network",
46-
],
4741
deps = [":selenium_manager"] + all_crate_deps(
4842
normal = True,
4943
normal_dev = True,

0 commit comments

Comments
 (0)