Skip to content

Commit 767c87e

Browse files
committed
Making a test depend on local resources, not a web page hosted elsewhere
1 parent 015b767 commit 767c87e

File tree

2 files changed

+35
-4
lines changed

2 files changed

+35
-4
lines changed

common/src/web/logEntryAdded.html

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
<html>
2+
3+
<body>
4+
5+
<h1>Long entry added events</h1>
6+
7+
<button id="consoleLog" onclick="helloWorld()">Click me for console logs</button>
8+
9+
<button id="consoleError" onclick="consoleError()">Click me for console error</button>
10+
11+
<button id="jsException" onclick="createError()">Click me for jsException logs</button>
12+
13+
<button id="logWithStacktrace" onclick="bar()">Click me to get an error with stacktrace</button>
14+
15+
<script>
16+
function helloWorld() {
17+
console.log('Hello, world!')
18+
}
19+
20+
function createError() { throw new Error('Not working') }
21+
22+
function foo() { throw new Error('Not working'); }
23+
24+
function bar() { foo(); }
25+
26+
function consoleError() { console.error('I am console error'); }
27+
</script>
28+
29+
</body>
30+
31+
</html>

java/test/org/openqa/selenium/devtools/WindowSwitchingTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class WindowSwitchingTest extends DevToolsTestBase {
3636
public void shouldBeAbleToSwitchWindowsAndCloseTheOriginal() {
3737
WebDriver driver = new Augmenter().augment(this.driver);
3838

39-
driver.get("https://www.selenium.dev");
39+
driver.get(pages.xhtmlTestPage);
4040

4141
String originalWindow = driver.getWindowHandle();
4242
driver.switchTo().newWindow(WindowType.TAB);
@@ -48,7 +48,7 @@ public void shouldBeAbleToSwitchWindowsAndCloseTheOriginal() {
4848
// tab
4949
driver.switchTo().window(originalWindow).close();
5050
driver.switchTo().window(newWindowHandle);
51-
driver.get("https://www.selenium.dev/documentation/webdriver/browser_manipulation/");
51+
driver.get(pages.echoPage);
5252

5353
List<TargetInfo> updatedTargets =
5454
this.devTools.send(this.devTools.getDomains().target().getTargets());
@@ -65,7 +65,7 @@ public void shouldBeAbleToCreateSessionForANewTab() {
6565
devTools.createSession();
6666
addConsoleLogListener(devTools);
6767

68-
driver.get("https://www.selenium.dev/selenium/web/bidi/logEntryAdded.html");
68+
driver.get(appServer.whereIs("logEntryAdded.html"));
6969

7070
List<TargetInfo> originalTargets = devTools.send(devTools.getDomains().target().getTargets());
7171
driver.findElement(By.id("consoleLog")).click();
@@ -77,7 +77,7 @@ public void shouldBeAbleToCreateSessionForANewTab() {
7777
devTools.createSession(windowHandle);
7878
addConsoleLogListener(devTools);
7979

80-
driver.get("https://www.selenium.dev/selenium/web/bidi/logEntryAdded.html");
80+
driver.get(appServer.whereIs("logEntryAdded.html"));
8181
driver.findElement(By.id("consoleLog")).click();
8282

8383
List<TargetInfo> updatedTargets =

0 commit comments

Comments
 (0)