Skip to content

Commit 8847928

Browse files
committed
rb - Delete Legacy SafariDriver #2725
1 parent 1b5aebe commit 8847928

File tree

9 files changed

+16
-445
lines changed

9 files changed

+16
-445
lines changed

rb/build.desc

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -279,10 +279,7 @@ ruby_library(name = "safari",
279279
"lib/selenium/webdriver/safari/**/*.rb",
280280
"lib/selenium/webdriver/safari.rb"
281281
],
282-
deps = [":common"],
283-
resources = [
284-
{ "//javascript/safari-driver:client": "rb/lib/selenium/webdriver/safari/resources/client.js"}
285-
]
282+
deps = [":common"]
286283
)
287284

288285
ruby_test(name = "safari",

rb/lib/selenium/webdriver/common/driver.rb

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,7 @@ def for(browser, opts = {})
6565
when :phantomjs
6666
PhantomJS::Bridge.new(opts)
6767
when :safari
68-
if Safari::LegacyBridge.legacy?
69-
Safari::LegacyBridge.new(opts)
70-
else
71-
Safari::AppleBridge.new(opts)
72-
end
68+
Safari::Bridge.new(opts)
7369
else
7470
raise ArgumentError, "unknown driver: #{browser.inspect}"
7571
end

rb/lib/selenium/webdriver/safari.rb

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,5 @@ def driver_path
7171
end # WebDriver
7272
end # Selenium
7373

74-
require 'selenium/webdriver/safari/browser'
75-
require 'selenium/webdriver/safari/server'
76-
require 'selenium/webdriver/safari/options'
77-
require 'selenium/webdriver/safari/legacy_bridge'
78-
require 'selenium/webdriver/safari/apple_bridge'
74+
require 'selenium/webdriver/safari/bridge'
7975
require 'selenium/webdriver/safari/service'
80-
81-
Selenium::WebDriver::Safari::Bridge = Selenium::WebDriver::Safari::LegacyBridge

rb/lib/selenium/webdriver/safari/apple_bridge.rb renamed to rb/lib/selenium/webdriver/safari/bridge.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ module Selenium
2121
module WebDriver
2222
module Safari
2323
# @api private
24-
class AppleBridge < Remote::Bridge
24+
class Bridge < Remote::Bridge
2525
def initialize(opts = {})
2626
opts[:desired_capabilities] ||= Remote::Capabilities.safari
2727
port = opts.delete(:port) || Service::DEFAULT_PORT
@@ -45,7 +45,7 @@ def quit
4545
def extract_service_args(args = {})
4646
args.key?(:port) ? ["--port=#{args[:port]}"] : []
4747
end
48-
end # AppleBridge
48+
end # Bridge
4949
end # Safari
5050
end # WebDriver
5151
end # Selenium

rb/lib/selenium/webdriver/safari/browser.rb

Lines changed: 0 additions & 38 deletions
This file was deleted.

rb/lib/selenium/webdriver/safari/legacy_bridge.rb

Lines changed: 0 additions & 138 deletions
This file was deleted.

rb/lib/selenium/webdriver/safari/options.rb

Lines changed: 0 additions & 61 deletions
This file was deleted.

0 commit comments

Comments
 (0)