Skip to content

Commit 8e48e08

Browse files
authored
[java] Fix page ranges issue in PrintOptions (#11172) (#11174)
1 parent 0ba1b14 commit 8e48e08

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

java/src/org/openqa/selenium/print/PrintOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ public Map<String, Object> toMap() {
121121
options.put("background", getBackground());
122122
final String[] effectivePageRanges = getPageRanges();
123123
if (effectivePageRanges != null) {
124-
options.put("effectivePageRanges", effectivePageRanges);
124+
options.put("pageRanges", effectivePageRanges);
125125
}
126126
options.put("margin", getPageMargin());
127127

java/test/org/openqa/selenium/print/PrintOptionsTest.java

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
import org.junit.jupiter.api.Tag;
2222
import static org.assertj.core.api.Assertions.assertThat;
2323

24+
import java.util.Map;
25+
2426

2527
@Tag("UnitTests")
2628
class PrintOptionsTest {
@@ -46,4 +48,21 @@ void setsValuesAsPassed() {
4648
assertThat(printOptions.getBackground()).isTrue();
4749
assertThat(printOptions.getShrinkToFit()).isFalse();
4850
}
51+
52+
@Test
53+
void toMapContainsProperKey() {
54+
PrintOptions printOptions = new PrintOptions();
55+
56+
printOptions.setPageRanges("1-2");
57+
58+
Map<String, Object> map = printOptions.toMap();
59+
assertThat(map.size()).isEqualTo(7);
60+
assertThat(map.containsKey("page")).isTrue();
61+
assertThat(map.containsKey("orientation")).isTrue();
62+
assertThat(map.containsKey("scale")).isTrue();
63+
assertThat(map.containsKey("shrinkToFit")).isTrue();
64+
assertThat(map.containsKey("background")).isTrue();
65+
assertThat(map.containsKey("pageRanges")).isTrue();
66+
assertThat(map.containsKey("margin")).isTrue();
67+
}
4968
}

0 commit comments

Comments
 (0)