Skip to content

Commit 973a069

Browse files
luke-hillbarancev
authored andcommitted
Move some require statements around, update some comments
1 parent e94359b commit 973a069

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

Rakefile

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,22 @@ require 'rake_tasks/crazy_fun/mappings/rake_mappings'
2525
require 'rake_tasks/crazy_fun/mappings/ruby_mappings'
2626
require 'rake_tasks/crazy_fun/mappings/tasks'
2727

28-
# Location of all new methods
28+
# Location of all new (non-CrazyFun) methods
29+
require 'rake_tasks/selenium_rake/browsers'
2930
require 'rake_tasks/selenium_rake/checks'
31+
require 'rake_tasks/selenium_rake/cpp_formatter'
3032
require 'rake_tasks/selenium_rake/ie_generator'
3133
require 'rake_tasks/selenium_rake/java_formatter'
32-
require 'rake_tasks/selenium_rake/cpp_formatter'
3334
require 'rake_tasks/selenium_rake/type_definitions_generator'
3435

35-
# Our modifications to the Rake library
36+
# Our modifications to the Rake / Bazel libraries
37+
require 'rake/task'
3638
require 'rake_tasks/rake/task'
3739
require 'rake_tasks/rake/dsl'
40+
require 'rake_tasks/bazel/task'
3841

39-
# These are the final items mixed into the global NS, should be namespaced correctly
42+
# These are the final items mixed into the global NS
43+
# These need moving into correct namespaces, and not be globally included
4044
require 'rake_tasks/bazel'
4145
require 'rake_tasks/copyright'
4246
require 'rake_tasks/python'

rake_tasks/bazel.rb

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
require 'pp'
22
require 'open3'
3-
require 'rake/task'
4-
require 'rake_tasks/selenium_rake/checks'
5-
require 'rake_tasks/bazel/task'
63

74
module Bazel
85
def self.execute(kind, args, target, &block)

rake_tasks/python.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
require 'rake_tasks/selenium_rake/browsers'
21

32
def py_exe
43
if ENV.key?('python')

0 commit comments

Comments
 (0)