Skip to content

Commit a91690b

Browse files
committed
Switch to Marionette by default in the Python client
Marionette tests can be run using ./go //py:marionette_test:run
1 parent 5b85c32 commit a91690b

File tree

6 files changed

+21
-13
lines changed

6 files changed

+21
-13
lines changed

py/build.desc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ py_test(
2020

2121
py_test(
2222
name = "marionette_test",
23-
deps = [ ":test_ff" ],
23+
deps = [ ":test_marionette" ],
2424
browsers = [ "marionette" ])
2525

2626
py_test(

py/selenium/webdriver/common/desired_capabilities.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class DesiredCapabilities(object):
5252
"version": "",
5353
"platform": "ANY",
5454
"javascriptEnabled": True,
55-
"marionette": False,
55+
"marionette": True,
5656
}
5757

5858
INTERNETEXPLORER = {

py/test/selenium/webdriver/firefox/ff_launcher_tests.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,24 +23,26 @@
2323
class FirefoxLauncherTests (unittest.TestCase):
2424

2525
def testLaunchAndCloseBrowser(self):
26-
self.webdriver = webdriver.Firefox()
26+
capabilities = {'marionette': False}
27+
self.webdriver = webdriver.Firefox(capabilities=capabilities)
2728
self.webdriver.quit()
2829

2930
def testDoubleClose(self):
30-
self.webdriver = webdriver.Firefox()
31+
capabilities = {'marionette': False}
32+
self.webdriver = webdriver.Firefox(capabilities=capabilities)
3133
self.webdriver.close()
3234
self.webdriver.close()
3335
self.webdriver.quit()
3436

3537
def test_we_can_launch_multiple_firefox_instances(self):
36-
self.webdriver1 = webdriver.Firefox()
37-
self.webdriver2 = webdriver.Firefox()
38-
self.webdriver3 = webdriver.Firefox()
38+
capabilities = {'marionette': False}
39+
self.webdriver1 = webdriver.Firefox(capabilities=capabilities)
40+
self.webdriver2 = webdriver.Firefox(capabilities=capabilities)
41+
self.webdriver3 = webdriver.Firefox(capabilities=capabilities)
3942
self.webdriver1.quit()
4043
self.webdriver2.quit()
4144
self.webdriver3.quit()
4245

4346
if __name__ == "__main__":
4447
logging.basicConfig(level=logging.INFO)
4548
unittest.main()
46-

py/test/selenium/webdriver/firefox/ff_profile_tests.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@
3737
class TestFirefoxProfile:
3838

3939
def setup_method(self, method):
40-
self.driver = webdriver.Firefox()
40+
self.capabilities = {'marionette': False}
41+
self.driver = webdriver.Firefox(capabilities=self.capabilities)
4142
self.webserver = SimpleWebServer()
4243
self.webserver.start()
4344

@@ -49,7 +50,9 @@ def test_that_we_can_accept_a_profile(self):
4950
profile1.update_preferences()
5051

5152
profile2 = webdriver.FirefoxProfile(profile1.path)
52-
driver = webdriver.Firefox(firefox_profile=profile2)
53+
driver = webdriver.Firefox(
54+
capabilities=self.capabilities,
55+
firefox_profile=profile2)
5356
title = driver.title
5457
driver.quit()
5558
assert "Hello WebDriver" == title

py/test/selenium/webdriver/firefox/ff_select_support_class_tests.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,16 @@
1717

1818

1919
from selenium import webdriver
20-
from selenium.test.selenium.webdriver.common import select_class_tests
20+
from selenium.test.selenium.webdriver.common import select_class_tests
2121
from selenium.test.selenium.webdriver.common.webserver import SimpleWebServer
2222

2323
def setup_module(module):
2424
webserver = SimpleWebServer()
2525
webserver.start()
2626
FirefoxSelectElementHandlingTests.webserver = webserver
27-
FirefoxSelectElementHandlingTests.driver = webdriver.Firefox()
27+
capabilities = {'marionette': False}
28+
FirefoxSelectElementHandlingTests.driver = webdriver.Firefox(
29+
capabilities=capabilities)
2830

2931

3032
class FirefoxSelectElementHandlingTests(select_class_tests.WebDriverSelectSupportTests):
@@ -34,4 +36,3 @@ class FirefoxSelectElementHandlingTests(select_class_tests.WebDriverSelectSuppor
3436
def teardown_module(module):
3537
FirefoxSelectElementHandlingTests.driver.quit()
3638
FirefoxSelectElementHandlingTests.webserver.stop()
37-

rake-tasks/browsers.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
:dir => "firefox", # Directory to put tests in/read tests from
1010
:file_string => "ff", # Browser-string to use in test filenames
1111
:class => "Firefox", # As per py/selenium/webdriver/__init__.py
12+
:constructor_args => "capabilities={'marionette': False}",
1213
:resources => [
1314
{ "//javascript/firefox-driver:webdriver" => "selenium/webdriver/firefox/" },
1415
{ "//cpp:noblur" => "selenium/webdriver/firefox/x86/x_ignore_nofocus.so" },
@@ -27,6 +28,7 @@
2728
:dir => "firefox", # Directory to put tests in/read tests from
2829
:file_string => "marionette", # Browser-string to use in test filenames
2930
:class => "Firefox", # As per py/selenium/webdriver/__init__.py
31+
:constructor_args => "capabilities={'marionette': True}"
3032
},
3133
:java => {
3234
:class => "org.openqa.selenium.firefox.SynthesizedFirefoxDriver",

0 commit comments

Comments
 (0)