Fail if an error is not thrown.

joshbruning · lukeis · commit ae3e1bfebf16 · 2016-04-07T10:51:59.000-07:00
Fix test that intends to check that an
error is thrown but doesn't. fail()
throws an Error which was previously
ignored under the same condition that
the expected Error was ignored.

Signed-off-by: Luke Inman-Semerau &lt;luke.semerau@gmail.com&gt;
diff --git a/java/client/test/org/openqa/selenium/support/ui/SlowLoadableComponentTest.java b/java/client/test/org/openqa/selenium/support/ui/SlowLoadableComponentTest.java
@@ -58,10 +58,11 @@ public void testShouldThrowAnErrorIfCallingLoadDoesNotCauseTheComponentToLoadBef
     FakeClock clock = new FakeClock();
     try {
       new BasicSlowLoader(clock, 2).get();
-      fail();
     } catch (Error e) {
       // We expect to time out
+      return;
     }
+    fail();
   }
 
   @Test

Original file line number	Diff line number	Diff line change
`@@ -58,10 +58,11 @@ public void testShouldThrowAnErrorIfCallingLoadDoesNotCauseTheComponentToLoadBef`
`58`	`58`	`FakeClock clock = new FakeClock();`
`59`	`59`	`try {`
`60`	`60`	`new BasicSlowLoader(clock, 2).get();`
`61`		`- fail();`
`62`	`61`	`} catch (Error e) {`
`63`	`62`	`// We expect to time out`
	`63`	`+ return;`
`64`	`64`	`}`
	`65`	`+ fail();`
`65`	`66`	`}`
`66`	`67`
`67`	`68`	`@Test`