Revert "[java] only allow enabled select lists for Select class"

This reverts commit 25b30ff

Author: titusfortner

java/src/org/openqa/selenium/support/ui/Select.java

@@ -45,14 +45,10 @@ public class Select implements ISelect, WrapsElement {
   public Select(WebElement element) {
     String tagName = element.getTagName();
 
-    if (!"select".equalsIgnoreCase(tagName)) {
+    if (null == tagName || !"select".equals(tagName.toLowerCase())) {
       throw new UnexpectedTagNameException("select", tagName);
     }
 
-    if (!element.isEnabled()) {
-      throw new UnsupportedOperationException("Select element is disabled and may not be used.");
-    }
-
     this.element = element;
 
     String value = element.getDomAttribute("multiple");
@@ -113,6 +109,8 @@ public WebElement getFirstSelectedOption() {
    */
   @Override
   public void selectByVisibleText(String text) {
+    assertSelectIsEnabled();
+
     // try to find the option via XPATH ...
     List<WebElement> options =
       element.findElements(By.xpath(".//option[normalize-space(.) = " + Quotes.escape(text) + "]"));
@@ -177,6 +175,7 @@ private String getLongestSubstringWithoutSpace(String s) {
    */
   @Override
   public void selectByIndex(int index) {
+    assertSelectIsEnabled();
     setSelectedByIndex(index, true);
   }
 
@@ -191,6 +190,7 @@ public void selectByIndex(int index) {
    */
   @Override
   public void selectByValue(String value) {
+    assertSelectIsEnabled();
     for (WebElement option : findOptionsByValue(value)) {
       setSelected(option, true);
       if (!isMultiple()) {
@@ -327,6 +327,12 @@ private void assertOptionIsEnabled(WebElement option, boolean select) {
     }
   }
 
+  private void assertSelectIsEnabled() {
+    if (!element.isEnabled()) {
+      throw new UnsupportedOperationException("You may not select an option in disabled select");
+    }
+  }
+
   @Override
   public boolean equals(Object o) {
     if (!(o instanceof Select)) {

java/test/org/openqa/selenium/support/ui/SelectElementTest.java

@@ -43,13 +43,6 @@ void shouldThrowAnExceptionIfTheElementIsNotASelectElement() {
         .isThrownBy(() -> new Select(selectElement));
   }
 
-  @Test
-  void shouldThrowAnExceptionIfTheElementIsDisabled() {
-    WebElement selectElement = driver.findElement(By.name("no-select"));
-    assertThatExceptionOfType(UnsupportedOperationException.class)
-      .isThrownBy(() -> new Select(selectElement));
-  }
-
   @Test
   void shouldIndicateThatASelectCanSupportMultipleOptions() {
     WebElement selectElement = driver.findElement(By.name("multi"));