Skip to content

Commit b619cda

Browse files
committed
fixing grid test compilation error, one test failure
1 parent 49dd3b2 commit b619cda

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

java/server/src/org/openqa/selenium/remote/server/SeleniumServer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public void setConfiguration(StandaloneConfiguration configuration) {
8383
}
8484

8585
public void boot() {
86-
if (configuration.jettyThreads > 0) {
86+
if (configuration.jettyThreads != null && configuration.jettyThreads > 0) {
8787
server = new Server(new QueuedThreadPool(configuration.jettyThreads));
8888
} else {
8989
server = new Server();

java/server/test/org/openqa/grid/internal/utils/SelfRegisteringRemoteTest.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,12 @@ public int getRealPort() {
2727
};
2828
RegistrationRequest config = new RegistrationRequest();
2929
config.setRole(GridRole.NODE);
30-
config.getConfiguration().put(RegistrationRequest.HUB_HOST, "localhost");
31-
config.getConfiguration().put(RegistrationRequest.HUB_PORT, 4444);
32-
config.getConfiguration().put(RegistrationRequest.PORT, 0);
33-
config.getConfiguration().put(RegistrationRequest.REMOTE_HOST, "http://localhost:0/");
30+
config.getConfiguration().port = 0;
31+
config.getConfiguration().hub = "http://locahost:4444";
3432
SelfRegisteringRemote remote = new SelfRegisteringRemote(config);
3533
remote.setRemoteServer(server);
3634
remote.updateConfigWithRealPort();
37-
String host = (String) remote.getConfiguration().get(RegistrationRequest.REMOTE_HOST);
35+
String host = (String) remote.getConfiguration().getRemoteHost();
3836
assertEquals("Ensure that the remote host is updated properly",
3937
"http://localhost:" + server.getRealPort(), host);
4038

0 commit comments

Comments
 (0)