Remove duplicate syserr output from SM

Author: shs96c

java/src/org/openqa/selenium/manager/SeleniumManager.java

@@ -113,7 +113,6 @@ private static Result runCommand(Path binary, List<String> arguments) {
     try {
       CommandLine command =
           new CommandLine(binary.toAbsolutePath().toString(), arguments.toArray(new String[0]));
-      command.copyOutputTo(System.err);
       command.executeAsync();
       command.waitFor(10000); // A generous timeout
       if (command.isRunning()) {
@@ -130,16 +129,8 @@ private static Result runCommand(Path binary, List<String> arguments) {
     if (!output.isEmpty()) {
       try {
         jsonOutput = new Json().toType(output, SeleniumManagerOutput.class);
-        jsonOutput.logs.forEach(
-            logged -> {
-              if (logged.level.equalsIgnoreCase(WARN)) {
-                LOG.warning(logged.message);
-              }
-              if (logged.level.equalsIgnoreCase(DEBUG) || logged.level.equalsIgnoreCase(INFO)) {
-                LOG.fine(logged.message);
-              }
-            });
-        dump = jsonOutput.result.message;
+        jsonOutput.getLogs().forEach(logged -> LOG.log(logged.getLevel(), logged.getMessage()));
+        dump = jsonOutput.getResult().getMessage();
       } catch (JsonException e) {
         failedToParse = e;
       }
@@ -152,7 +143,7 @@ private static Result runCommand(Path binary, List<String> arguments) {
       throw new WebDriverException(
           "Failed to parse json output, executed: " + arguments + "\n" + dump, failedToParse);
     }
-    return jsonOutput.result;
+    return jsonOutput.getResult();
   }
 
   /**

java/src/org/openqa/selenium/manager/SeleniumManagerOutput.java

@@ -18,12 +18,14 @@
 
 import java.util.List;
 import java.util.Objects;
+import java.util.logging.Level;
+import org.openqa.selenium.internal.Require;
 import org.openqa.selenium.json.JsonInput;
 
 public class SeleniumManagerOutput {
 
-  public List<Log> logs;
-  public Result result;
+  private List<Log> logs;
+  private Result result;
 
   public List<Log> getLogs() {
     return logs;
@@ -42,43 +44,76 @@ public void setResult(Result result) {
   }
 
   public static class Log {
-    public String level;
-    long timestamp;
-    public String message;
+    private final Level level;
+    private final long timestamp;
+    private final String message;
 
-    public String getLevel() {
-      return level;
+    public Log(Level level, long timestamp, String message) {
+      this.level = Require.nonNull("level", level);
+      this.timestamp = timestamp;
+      this.message = Require.nonNull("message", message);
     }
 
-    public void setLevel(String level) {
-      this.level = level;
+    public Level getLevel() {
+      return level;
     }
 
     public long getTimestamp() {
       return timestamp;
     }
 
-    public void setTimestamp(long timestamp) {
-      this.timestamp = timestamp;
-    }
-
     public String getMessage() {
       return message;
     }
 
-    public void setMessage(String message) {
-      this.message = message;
+    private static Log fromJson(JsonInput input) {
+      Level level = Level.FINE;
+      long timestamp = System.currentTimeMillis();
+      String message = "";
+
+      input.beginObject();
+      while (input.hasNext()) {
+        switch (input.nextName()) {
+          case "level":
+            switch (input.nextString().toLowerCase()) {
+              case "error":
+              case "warn":
+                level = Level.WARNING;
+                break;
+
+              case "info":
+                level = Level.INFO;
+                break;
+
+              default:
+                level = Level.FINE;
+                break;
+            }
+            break;
+
+          case "timestamp":
+            timestamp = input.nextNumber().longValue();
+            break;
+
+          case "message":
+            message = input.nextString();
+            break;
+        }
+      }
+      input.endObject();
+
+      return new Log(level, timestamp, message);
     }
   }
 
   public static class Result {
-    public int code;
-    public String message;
-    public String driverPath;
-    public String browserPath;
+    private final int code;
+    private final String message;
+    private final String driverPath;
+    private final String browserPath;
 
     public Result(String driverPath) {
-      this.driverPath = driverPath;
+      this(0, null, driverPath, null);
     }
 
     public Result(int code, String message, String driverPath, String browserPath) {
@@ -92,34 +127,18 @@ public int getCode() {
       return code;
     }
 
-    public void setCode(int code) {
-      this.code = code;
-    }
-
     public String getMessage() {
       return message;
     }
 
-    public void setMessage(String message) {
-      this.message = message;
-    }
-
     public String getDriverPath() {
       return driverPath;
     }
 
-    public void setDriverPath(String driverPath) {
-      this.driverPath = driverPath;
-    }
-
     public String getBrowserPath() {
       return browserPath;
     }
 
-    public void setBrowserPath(String browserPath) {
-      this.browserPath = browserPath;
-    }
-
     @Override
     public String toString() {
       return "Result{"
@@ -154,7 +173,7 @@ public int hashCode() {
       return Objects.hash(code, message, driverPath, browserPath);
     }
 
-    public static Result fromJson(JsonInput input) {
+    private static Result fromJson(JsonInput input) {
       int code = 0;
       String message = null;
       String driverPath = null;