Skip to content

Commit be43937

Browse files
committed
Strengthen java deps now rules_jvm_external has been updated.
1 parent 3c539b8 commit be43937

File tree

3 files changed

+784
-307
lines changed

3 files changed

+784
-307
lines changed

java/client/src/org/openqa/selenium/remote/http/netty/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ java_library(
1111
"//java/client/src/org/openqa/selenium/remote/http",
1212
artifact("com.google.guava:guava"),
1313
artifact("com.typesafe.netty:netty-reactive-streams"),
14-
artifact("io.netty:netty-all"),
1514
artifact("org.asynchttpclient:async-http-client"),
1615
],
1716
)

java/maven_deps.bzl

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ def selenium_java_deps():
77
"com.beust:jcommander:1.72",
88
"com.github.javaparser:javaparser-core:3.15.5",
99
"com.google.code.gson:gson:2.8.6",
10-
"com.google.guava:guava:28.1-jre",
10+
"com.google.guava:guava:28.2g-jre",
1111
"com.google.auto:auto-common:0.10",
1212
"com.google.auto.service:auto-service:1.0-rc6",
1313
"com.google.auto.service:auto-service-annotations:1.0-rc6",
@@ -21,6 +21,7 @@ def selenium_java_deps():
2121
"junit:junit:4.12",
2222
"net.bytebuddy:byte-buddy:1.10.2",
2323
"net.sourceforge.htmlunit:htmlunit:2.36.0",
24+
"net.sourceforge.htmlunit:htmlunit-core-js:2.36.0",
2425
"org.apache.commons:commons-exec:1.3",
2526
"org.assertj:assertj-core:3.13.2",
2627
"org.asynchttpclient:async-http-client:2.10.3",
@@ -32,6 +33,7 @@ def selenium_java_deps():
3233
"org.eclipse.jetty:jetty-util:9.4.22.v20191022",
3334
"org.eclipse.mylyn.github:org.eclipse.egit.github.core:2.1.5",
3435
"org.hamcrest:hamcrest-all:1.3",
36+
"org.hamcrest:hamcrest-core:1.3",
3537
"org.mockito:mockito-core:3.1.0",
3638
"org.testng:testng:6.14.3",
3739
"org.zeromq:jeromq:0.5.1",
@@ -47,8 +49,12 @@ def selenium_java_deps():
4749
],
4850
),
4951
],
50-
fail_on_missing_checksum = False,
52+
excluded_artifacts = [
53+
"io.netty:netty-all", # Depend on the actual things you need
54+
],
55+
fail_on_missing_checksum = True,
5156
fetch_sources = True,
57+
strict_visibility = True,
5258
repositories = [
5359
"https://repo1.maven.org/maven2",
5460
"https://jcenter.bintray.com/",

0 commit comments

Comments
 (0)