Skip to content

Commit c2dda23

Browse files
committed
[js] Improve atoms loading under Bazel
1 parent 9e7adc7 commit c2dda23

File tree

3 files changed

+25
-7
lines changed

3 files changed

+25
-7
lines changed

javascript/node/selenium-webdriver/BUILD.bazel

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ mocha_test(
101101
size = "small",
102102
chdir = package_name(),
103103
data = [
104+
":node_modules/@bazel/runfiles",
104105
":node_modules/jszip",
105106
":node_modules/mocha",
106107
":node_modules/mocha-junit-reporter",
@@ -109,6 +110,10 @@ mocha_test(
109110
"//:node_modules/selenium-webdriver",
110111
"//common/extensions:js-lib",
111112
"//common/src/web:js-lib",
113+
"//javascript/node/selenium-webdriver/lib/atoms:find-elements",
114+
"//javascript/node/selenium-webdriver/lib/atoms:get_attribute",
115+
"//javascript/node/selenium-webdriver/lib/atoms:is_displayed",
116+
"//javascript/node/selenium-webdriver/lib/atoms:mutation-listener",
112117
] + SMALL_TESTS + TEST_DATA,
113118
tags = [
114119
"skip-remote",
@@ -133,6 +138,10 @@ mocha_test(
133138
"//:node_modules/selenium-webdriver",
134139
"//common/extensions:js-lib",
135140
"//common/src/web:js-lib",
141+
"//javascript/node/selenium-webdriver/lib/atoms:find-elements",
142+
"//javascript/node/selenium-webdriver/lib/atoms:get_attribute",
143+
"//javascript/node/selenium-webdriver/lib/atoms:is_displayed",
144+
"//javascript/node/selenium-webdriver/lib/atoms:mutation-listener",
136145
],
137146
env = {
138147
"SELENIUM_BROWSER": browser,

javascript/node/selenium-webdriver/lib/atoms/BUILD.bazel

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,26 +10,35 @@ js_binary(
1010
js_run_binary(
1111
name = "is_displayed",
1212
srcs = ["//javascript/atoms/fragments:is-displayed.js"],
13-
args = ["javascript/atoms/fragments/is-displayed.js"],
14-
stdout = "is-displayed.js",
13+
outs = ["is-displayed.js"],
14+
args = [
15+
"$(rootpath //javascript/atoms/fragments:is-displayed.js)",
16+
"$(rootpath :is-displayed.js)",
17+
],
1518
tool = ":make_atoms_module",
1619
visibility = ["//javascript/node/selenium-webdriver:__pkg__"],
1720
)
1821

1922
js_run_binary(
2023
name = "get_attribute",
2124
srcs = ["//javascript/webdriver/atoms:get-attribute.js"],
22-
args = ["javascript/webdriver/atoms/get-attribute.js"],
23-
stdout = "get-attribute.js",
25+
outs = ["get-attribute.js"],
26+
args = [
27+
"$(rootpath //javascript/webdriver/atoms:get-attribute.js)",
28+
"$(rootpath :get-attribute.js)",
29+
],
2430
tool = ":make_atoms_module",
2531
visibility = ["//javascript/node/selenium-webdriver:__pkg__"],
2632
)
2733

2834
js_run_binary(
2935
name = "find-elements",
3036
srcs = ["//javascript/atoms/fragments:find-elements.js"],
31-
args = ["javascript/atoms/fragments/find-elements.js"],
32-
stdout = "find-elements.js",
37+
outs = ["find-elements.js"],
38+
args = [
39+
"$(rootpath //javascript/atoms/fragments:find-elements.js)",
40+
"$(rootpath :find-elements.js)",
41+
],
3342
tool = ":make_atoms_module",
3443
visibility = ["//javascript/node/selenium-webdriver:__pkg__"],
3544
)

javascript/node/selenium-webdriver/lib/atoms/make-atoms-module.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ if (process.argv.length < 3) {
2626

2727
const buffer = fs.readFileSync(process.argv[2])
2828

29-
process.stdout.write(
29+
fs.writeFileSync(process.argv[3],
3030
`// GENERATED CODE - DO NOT EDIT
3131
module.exports = ${buffer.toString('utf8').trim()};
3232
`,

0 commit comments

Comments
 (0)