[js] Do not compress zip entries.

This causes errors on decompression if the zip contains a file that was
already compressed (such as a jar).

Fixes #640

Author: jleyba

javascript/node/selenium-webdriver/CHANGES.md

@@ -1,5 +1,8 @@
 ## v2.48.0-dev
 
+* FIXED: zip files created for transfer to a remote WebDriver server are no
+    longer compressed. If the zip contained a file that was already compressed,
+    the server would return an "invalid code lengths set" error.
 * FIXED: Surfaced the `loopback` option to `remote/SeleniumServer`. When set,
     the server will be accessed using the current host's loopback address.
 

javascript/node/selenium-webdriver/firefox/extension.js

@@ -69,7 +69,6 @@ function install(extension, dir) {
         return io.copy(extension, dst + '.xpi').then(returnId);
       } else {
         return checkedCall(fs.readFile, extension).then(function(buff) {
-          var zip = new AdmZip(buff);
           // TODO: find an async library for inflating a zip archive.
           new AdmZip(buff).extractAllTo(dst, true);
         }).then(returnId);

javascript/node/selenium-webdriver/firefox/profile.js

@@ -23,6 +23,7 @@
 'use strict';
 
 var AdmZip = require('adm-zip'),
+    AdmConstants = require('adm-zip/util/constants'),
     fs = require('fs'),
     path = require('path'),
     util = require('util'),
@@ -403,6 +404,7 @@ Profile.prototype.encode = function() {
   return this.writeToDisk(true).then(function(dir) {
     var zip = new AdmZip();
     zip.addLocalFolder(dir, '');
+    zip.getEntries()[0].header.method = AdmConstants.STORED;
     return io.tmpFile().then(function(file) {
       zip.writeZip(file);  // Sync! Why oh why :-(
       return promise.checkedNodeCall(fs.readFile, file);

javascript/node/selenium-webdriver/remote/index.js

@@ -18,6 +18,7 @@
 'use strict';
 
 var AdmZip = require('adm-zip'),
+    AdmConstants = require('adm-zip/util/constants'),
     fs = require('fs'),
     path = require('path'),
     url = require('url'),
@@ -351,6 +352,7 @@ FileDetector.prototype.handleFile = function(driver, filePath) {
 
     var zip = new AdmZip();
     zip.addLocalFile(filePath);
+    zip.getEntries()[0].header.method = AdmConstants.STORED;
 
     var command = new webdriver.Command(webdriver.CommandName.UPLOAD_FILE)
         .setParameter('file', zip.toBuffer().toString('base64'));