[java] ensure changes are visible for all threads

Author: joerg1985

java/src/org/openqa/selenium/devtools/idealized/Network.java

@@ -59,7 +59,7 @@ public abstract class Network<AUTHREQUIRED, REQUESTPAUSED> {
 
   private final Map<Predicate<URI>, Supplier<Credentials>> authHandlers = new LinkedHashMap<>();
   private final Filter defaultFilter = next -> next::execute;
-  private Filter filter = defaultFilter;
+  private volatile Filter filter = defaultFilter;
   protected final DevTools devTools;
 
   private final AtomicBoolean networkInterceptorRegistered = new AtomicBoolean();
@@ -73,7 +73,9 @@ public void disable() {
     devTools.send(disableFetch());
     devTools.send(enableNetworkCaching());
 
-    authHandlers.clear();
+    synchronized (authHandlers) {
+      authHandlers.clear();
+    }
     filter = defaultFilter;
   }
 
@@ -128,7 +130,9 @@ public void addAuthHandler(
     Require.nonNull("URI predicate", whenThisMatches);
     Require.nonNull("Credentials", useTheseCredentials);
 
-    authHandlers.put(whenThisMatches, useTheseCredentials);
+    synchronized (authHandlers) {
+      authHandlers.put(whenThisMatches, useTheseCredentials);
+    }
 
     prepareToInterceptTraffic();
   }
@@ -250,11 +254,13 @@ public void prepareToInterceptTraffic() {
   protected Optional<Credentials> getAuthCredentials(URI uri) {
     Require.nonNull("URI", uri);
 
-    return authHandlers.entrySet().stream()
-        .filter(entry -> entry.getKey().test(uri))
-        .map(Map.Entry::getValue)
-        .map(Supplier::get)
-        .findFirst();
+    synchronized (authHandlers) {
+      return authHandlers.entrySet().stream()
+          .filter(entry -> entry.getKey().test(uri))
+          .map(Map.Entry::getValue)
+          .map(Supplier::get)
+          .findFirst();
+    }
   }
 
   protected HttpMethod convertFromCdpHttpMethod(String method) {